-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issue-5850 - Settle override conflicts between edges and propagate changes #7025
Open
AlonNavon
wants to merge
33
commits into
npm:latest
Choose a base branch
from
ali-security:fix-overrides-5850
base: latest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
865070c
Settle overrides conflicts between edges, and propagate changes to th…
AlonNavon cd20196
cleanup
AlonNavon 0cad4e0
Optimization
AlonNavon 6b276f3
Fix override sets comparisons
AlonNavon fff3072
Add comparator
AlonNavon e97176e
Check for undefined
AlonNavon 19155ed
Another place
AlonNavon dedbccf
Fix
AlonNavon 4a83786
Lint fixes
AlonNavon 7ee2f2e
Added tests
AlonNavon 0917421
Overrides aren't inherited from parent, but from to nodes
AlonNavon 6d0ad42
Always use raw spec when analyzing overrides
AlonNavon 67d7d5c
Replaceability
AlonNavon 643cbea
Overridden status
AlonNavon c5f6e4a
Fix undefined bugs
AlonNavon 6c9bbf9
Parent doesn't matter to overrides
AlonNavon 63760d9
Update override set in reload
AlonNavon 6111630
Erroneous node
AlonNavon b42d4c8
Add comments
AlonNavon 7d97726
Code review fixes
AlonNavon 35e5790
Fix edge satisfaction logic
AlonNavon 35ce2f7
Fix dedupe logic
AlonNavon 5630954
Code review fixes
AlonNavon f859e92
Oops
AlonNavon 29f0750
Static function
AlonNavon 17ec457
Typo
AlonNavon 4cde831
Shouldn't throw
AlonNavon 701b125
CR fixes
AlonNavon b119f67
CR fixes
AlonNavon 3136b64
Move functions
AlonNavon 80126c7
Comments
AlonNavon c4b5338
Override sets unit tests
AlonNavon 9db1232
Clarify comment
AlonNavon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as resolved.
Sorry, something went wrong.