Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v9 unpublish bugfixes backport #7050

Merged
merged 2 commits into from
Dec 1, 2023
Merged

v9 unpublish bugfixes backport #7050

merged 2 commits into from
Dec 1, 2023

Conversation

wraithgar
Copy link
Member

Backports two fixes:

@wraithgar
fix: unpublish bugfixes (#7039)
edcac41 
- Properly work in workspace mode.  Previously setting the workspace
  meant the entire package was unpublished.  Now it follows the
  convention of acting as if you were running from the workspace
  directory.
 - Better checking of when you are unpublishing the last version of a
  package.  npm checks the actual manifest and compares it to the
  version you are asking to unpublish.
 - Error on ranges and tags.  npm doesn't unpublish ranges or tags, and
   giving those as inputs would give unexepected results.
 - Proper output of what was unpublished.  Previously the package (and
   sometimes version) displayed would not match what was actually
   unpublished.
 - Updated docs specifying that unpublishing with no parameters will
   only unpublish the version represented by the local package.json
@wraithgar
fix(unpublish): bubble up all errors parsing local package.json (#7049)
bae2ee5 
If the file is there and there is any error that's always a show stopper
@wraithgar wraithgar requested a review from a team as a code owner December 1, 2023 19:50
hashtagchris
hashtagchris approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@hashtagchris hashtagchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I couldn't think of a breaking change in behavior someone would be relying on.

@wraithgar wraithgar merged commit 8d9d735 into release/v9 Dec 1, 2023
32 of 33 checks passed
@wraithgar wraithgar deleted the gar/unpublish-v9 branch December 1, 2023 20:40
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hashtagchris hashtagchris hashtagchris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wraithgar @hashtagchris