chore: log if npm deprecate does not match any version
#7472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the package specification does not match any existing version, a verbose message is added to the log. Closes #7180
|
too much work to figure out which tests need to be adapted |
|
I think the test failures were preventing you from logging w/ the old log-shim. We added that guard when we finished the logging refactor. You will want to use const { log } = require('proc-log') |
wraithgar
reviewed
May 5, 2024
| @@ -66,6 +67,8 @@ class Deprecate extends BaseCommand { | |||
| body: packument, | |||
| ignoreBody: true, | |||
| })) | |||
| } else { | |||
| log.verbose('no version found for', p) | |||
There was a problem hiding this comment.
I could see an argument being made that this should be a warn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the package specification does not match any existing version, a verbose message is added to the log.
References
Closes #7180