Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache manifests not promises #7494

Merged
merged 4 commits into from
May 9, 2024
Merged

Cache manifests not promises #7494

merged 4 commits into from
May 9, 2024

Commits on May 8, 2024

  1. chore: disable progress on shellout exit tests

    These tests assert what happens if a shellout command like exec throws unexpected errors by checking what is written to stderr. Progress also gets written to stderr but is not always deterministic due to the nature of calling it via setInterval. So this disables progress for these tests so the stderr assertions can be relied on to be the same.
    wraithgar committed May 8, 2024
    Configuration menu
    Copy the full SHA
    6fc87bd View commit details
    Browse the repository at this point in the history
  2. chore: disable color in config tests

    The logging output was making bare string assertions fail
    wraithgar committed May 8, 2024
    Configuration menu
    Copy the full SHA
    b5086c0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4223f73 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. fix: avoid caching manifests as promises

    Originally this was in #7468:
    
    We backed off of it while we were rebuilding pacote's packument cache.
    
    Now that that's done we can assess this in isolation.  I think it makes
    sense.  The packument is cached here, all this is awaiting is
    normalization and ssri calculation.
    
    The only place this potentially does anything is in the premature
    loading of manifests in `#buildDepStep` when looking at problem edges.
    We can just wait till we need them and not throw a ton of requests in
    parallel before we actually need them.
    
    Removing the premature loading in problem edges will have to be a
    separate effort, as it is somehow load bearing
    wraithgar committed May 9, 2024
    Configuration menu
    Copy the full SHA
    64ab520 View commit details
    Browse the repository at this point in the history