Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont write log file for completion commands #7497

Merged
merged 1 commit into from
May 9, 2024

Conversation

lukekarrys
Copy link
Contributor

Since npm completion is implemented by calling npm completion -- arg1
this will write a logfile for that command. I noticed this as I was trying
to look through my logs for a recent command and found that it had been removed
since I used enough tab completions to fill logs-max.

Since npm completion is implemented by calling npm completion -- arg1
this will write a logfile for that command. I noticed this as I was trying
to look through my logs for a recent command and found that it had been removed
since I used enough tab completions to fill logs-max.
@lukekarrys lukekarrys requested a review from a team as a code owner May 9, 2024 19:09
@lukekarrys
Copy link
Contributor Author

Here's what a grep of my logs looked like previously:

❯ grep -r "argv" _logs/
_logs//2024-05-09T19_05_19_129Z-debug-0.log:8 verbose argv "completion" "--" "npm" "vi"
_logs//2024-05-09T19_05_18_423Z-debug-0.log:8 verbose argv "completion" "--" ""
_logs//2024-05-09T19_05_20_636Z-debug-0.log:8 verbose argv "completion" "--" "npm" "view" ""
_logs//2024-05-09T19_05_18_304Z-debug-0.log:8 verbose argv "completion"

@lukekarrys lukekarrys merged commit 6d456bb into latest May 9, 2024
23 checks passed
@lukekarrys lukekarrys deleted the lk/skip-log-file-for-completion branch May 9, 2024 20:06
@github-actions github-actions bot mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants