Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove json.stringify from all commands #7541

Merged
merged 1 commit into from
May 17, 2024

Conversation

lukekarrys
Copy link
Contributor

This converts all remaining commands/utils to use the display layer for formatting their json output

This converts all remaining commands/utils to use the display layer for formatting their json output
@lukekarrys lukekarrys requested a review from a team as a code owner May 17, 2024 06:16
@npm-cli-bot
Copy link
Collaborator

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only modules-only no-lock no-cache no-modules no-clean show-version run-script cache-only
peer-deps
no-clean
audit
npm@latest 26.091 ±0.82 10.780 ±0.06 11.768 ±0.06 1.569 ±0.03 1.535 ±0.01 1.278 ±0.00 8.311 ±0.09 1.297 ±0.01 0.147 ±0.01 0.170 ±0.00 15.028 ±0.00 2.156 ±0.04
#7541 27.907 ±0.65 10.736 ±0.03 11.770 ±0.03 1.557 ±0.03 1.551 ±0.01 1.280 ±0.02 8.259 ±0.05 1.290 ±0.02 0.139 ±0.00 0.166 ±0.00 14.899 ±0.05 2.127 ±0.01
app-medium clean lock-only cache-only modules-only no-lock no-cache no-modules no-clean show-version run-script cache-only
peer-deps
no-clean
audit
npm@latest 20.665 ±0.22 7.999 ±0.01 8.920 ±0.03 1.520 ±0.03 1.503 ±0.01 1.412 ±0.02 5.788 ±0.02 1.318 ±0.01 0.138 ±0.00 0.166 ±0.00 10.014 ±0.12 2.011 ±0.03
#7541 21.231 ±0.45 8.101 ±0.06 8.977 ±0.08 1.525 ±0.01 1.525 ±0.02 1.407 ±0.00 5.846 ±0.01 1.325 ±0.01 0.139 ±0.00 0.165 ±0.00 10.048 ±0.02 2.008 ±0.04

lib/npm.js Show resolved Hide resolved
@lukekarrys lukekarrys merged commit 61d5771 into latest May 17, 2024
23 checks passed
@lukekarrys lukekarrys deleted the lk/remove-json-stringify branch May 17, 2024 17:23
@github-actions github-actions bot mentioned this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants