Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exec): look in workspace and root for bin entries #7569

Merged
merged 1 commit into from
May 29, 2024

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented May 29, 2024

Closes: #7379

@wraithgar wraithgar requested a review from a team as a code owner May 29, 2024 16:44
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented May 29, 2024

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only modules-only no-lock no-cache no-modules no-clean show-version run-script cache-only
peer-deps
no-clean
audit
npm@latest 28.170 ±0.85 10.533 ±0.05 11.656 ±0.03 1.540 ±0.01 1.522 ±0.00 1.251 ±0.00 8.208 ±0.02 1.261 ±0.01 0.136 ±0.00 0.161 ±0.00 14.735 ±0.23 2.102 ±0.04
#7569 28.087 ±0.84 10.496 ±0.05 11.885 ±0.02 1.541 ±0.02 1.545 ±0.01 1.274 ±0.00 8.320 ±0.03 1.300 ±0.01 0.139 ±0.00 0.166 ±0.00 14.597 ±0.12 2.086 ±0.00
app-medium clean lock-only cache-only modules-only no-lock no-cache no-modules no-clean show-version run-script cache-only
peer-deps
no-clean
audit
npm@latest 21.671 ±0.06 7.872 ±0.04 8.877 ±0.01 1.492 ±0.01 1.501 ±0.00 1.381 ±0.01 5.735 ±0.04 1.294 ±0.01 0.136 ±0.00 0.165 ±0.00 9.827 ±0.18 1.964 ±0.01
#7569 21.478 ±0.31 8.011 ±0.03 8.928 ±0.03 1.526 ±0.00 1.531 ±0.01 1.422 ±0.01 5.844 ±0.04 1.315 ±0.02 0.138 ±0.00 0.164 ±0.00 9.829 ±0.02 1.991 ±0.01

Copy link
Contributor

@reggi reggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM

@wraithgar wraithgar merged commit 6b55646 into latest May 29, 2024
42 checks passed
@wraithgar wraithgar deleted the gar/exec-workspace-scope branch May 29, 2024 20:32
@github-actions github-actions bot mentioned this pull request May 29, 2024
@@ -54,7 +51,7 @@ class Exec extends BaseCommand {
localBin = resolve(this.npm.localDir, name, 'node_modules', '.bin')
// We also need to look for `bin` entries in the workspace package.json
// libnpmexec will NOT look in the project root for the bin entry
path = runPath
pkgPath = runPath

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] npm exec -w [workspace] doesn't local deps installed in parent-repository node_modules
4 participants