Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update notifier to consider node version #7876

Draft
wants to merge 1 commit into
base: latest
Choose a base branch
from

Conversation

milaninfy
Copy link
Contributor

@milaninfy milaninfy commented Oct 23, 2024

npm update notifier currently suggests latest npm version regardless of node version compatibility. This PR attempts to choose latest compatible version when suggesting npm update.

  • In Progress ( Half backed at this point ) May be it's appropriate to fix it in pacote while requesting manifest for npm, will close this once pacote changes are created and tested.
  • Unit tests pending.

fixes: #6836

Copy link

@Pjrich1313 Pjrich1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rerun from scratch with latest version of nps/debug and merge with duplication

Copy link

@Pjrich1313 Pjrich1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rerun debug nobes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] npm/node don't respect each other's versions
2 participants