Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up dependency graph repos #7920

Merged
merged 2 commits into from
Nov 25, 2024
Merged

chore: clean up dependency graph repos #7920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16db9a7
chore: update `npm-cli-repos.txt`
hashtagchris Nov 19, 2024
47b9c11
chore: associate `node-which` repo with `which` package
hashtagchris Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions DEPENDENCIES.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,16 +40,17 @@
"make-fetch-happen"
],
[
"@npmcli/smoke-tests",
"@npmcli/installed-package-contents",
"npm-pick-manifest",
"cacache",
"promzard"
],
[
"@npmcli/docs",
"@npmcli/smoke-tests",
"@npmcli/fs",
"npm-bundled",
"@npmcli/promise-spawn",
"npm-install-checks",
"npm-package-arg",
"normalize-package-data",
Expand All @@ -69,13 +70,12 @@
"semver",
"npm-normalize-package-bin",
"@npmcli/name-from-folder",
"@npmcli/promise-spawn",
"which",
"ini",
"hosted-git-info",
"proc-log",
"validate-npm-package-name",
"json-parse-even-better-errors",
"fs-minipass",
"ssri",
"unique-slug",
"@npmcli/node-gyp",
Expand Down
14 changes: 8 additions & 6 deletions DEPENDENCIES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ graph LR;
bin-links-->proc-log;
bin-links-->read-cmd-shim;
bin-links-->write-file-atomic;
cacache-->fs-minipass;
cacache-->npmcli-fs["@npmcli/fs"];
cacache-->ssri;
cacache-->unique-filename;
Expand Down Expand Up @@ -86,7 +85,6 @@ graph LR;
normalize-package-data-->semver;
npm-->abbrev;
npm-->cacache;
npm-->fs-minipass;
npm-->hosted-git-info;
npm-->ini;
npm-->init-package-json;
Expand Down Expand Up @@ -134,6 +132,7 @@ graph LR;
npm-->semver;
npm-->ssri;
npm-->validate-npm-package-name;
npm-->which;
npm-bundled-->npm-normalize-package-bin;
npm-install-checks-->semver;
npm-package-arg-->hosted-git-info;
Expand Down Expand Up @@ -200,6 +199,7 @@ graph LR;
npmcli-git-->npmcli-promise-spawn["@npmcli/promise-spawn"];
npmcli-git-->proc-log;
npmcli-git-->semver;
npmcli-git-->which;
npmcli-installed-package-contents-->npm-bundled;
npmcli-installed-package-contents-->npm-normalize-package-bin;
npmcli-map-workspaces-->npmcli-name-from-folder["@npmcli/name-from-folder"];
Expand All @@ -222,16 +222,18 @@ graph LR;
npmcli-package-json-->npmcli-git["@npmcli/git"];
npmcli-package-json-->proc-log;
npmcli-package-json-->semver;
npmcli-promise-spawn-->which;
npmcli-run-script-->npmcli-node-gyp["@npmcli/node-gyp"];
npmcli-run-script-->npmcli-package-json["@npmcli/package-json"];
npmcli-run-script-->npmcli-promise-spawn["@npmcli/promise-spawn"];
npmcli-run-script-->proc-log;
npmcli-run-script-->which;
npmcli-smoke-tests-->npmcli-eslint-config["@npmcli/eslint-config"];
npmcli-smoke-tests-->npmcli-mock-registry["@npmcli/mock-registry"];
npmcli-smoke-tests-->npmcli-promise-spawn["@npmcli/promise-spawn"];
npmcli-smoke-tests-->npmcli-template-oss["@npmcli/template-oss"];
npmcli-smoke-tests-->which;
pacote-->cacache;
pacote-->fs-minipass;
pacote-->npm-package-arg;
pacote-->npm-packlist;
pacote-->npm-pick-manifest;
Expand Down Expand Up @@ -786,6 +788,6 @@ packages higher up the chain.
- @npmcli/map-workspaces, @npmcli/run-script, libnpmaccess, libnpmorg, libnpmpublish, libnpmsearch, libnpmteam, init-package-json, npm-profile
- @npmcli/package-json, npm-registry-fetch
- @npmcli/git, make-fetch-happen
- @npmcli/installed-package-contents, npm-pick-manifest, cacache, promzard
- @npmcli/docs, @npmcli/smoke-tests, @npmcli/fs, npm-bundled, npm-install-checks, npm-package-arg, normalize-package-data, unique-filename, npm-packlist, bin-links, nopt, parse-conflict-json, read-package-json-fast, @npmcli/mock-globals, read
- @npmcli/eslint-config, @npmcli/template-oss, ignore-walk, semver, npm-normalize-package-bin, @npmcli/name-from-folder, @npmcli/promise-spawn, ini, hosted-git-info, proc-log, validate-npm-package-name, json-parse-even-better-errors, fs-minipass, ssri, unique-slug, @npmcli/node-gyp, @npmcli/redact, @npmcli/agent, minipass-fetch, @npmcli/query, cmd-shim, read-cmd-shim, write-file-atomic, abbrev, proggy, minify-registry-metadata, mute-stream, npm-audit-report, npm-user-validate
- @npmcli/smoke-tests, @npmcli/installed-package-contents, npm-pick-manifest, cacache, promzard
- @npmcli/docs, @npmcli/fs, npm-bundled, @npmcli/promise-spawn, npm-install-checks, npm-package-arg, normalize-package-data, unique-filename, npm-packlist, bin-links, nopt, parse-conflict-json, read-package-json-fast, @npmcli/mock-globals, read
- @npmcli/eslint-config, @npmcli/template-oss, ignore-walk, semver, npm-normalize-package-bin, @npmcli/name-from-folder, which, ini, hosted-git-info, proc-log, validate-npm-package-name, json-parse-even-better-errors, ssri, unique-slug, @npmcli/node-gyp, @npmcli/redact, @npmcli/agent, minipass-fetch, @npmcli/query, cmd-shim, read-cmd-shim, write-file-atomic, abbrev, proggy, minify-registry-metadata, mute-stream, npm-audit-report, npm-user-validate
3 changes: 2 additions & 1 deletion scripts/dependency-graph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,9 @@ function difference (set1, set2) {

// these have a different package name than the repo name, and are ours.
const aliases = {
semver: 'node-semver',
abbrev: 'abbrev-js',
semver: 'node-semver',
which: 'node-which',
}

// These are entries in npm-cli-repos.txt that correlate to namespaced repos.
Expand Down
11 changes: 2 additions & 9 deletions scripts/npm-cli-repos.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,12 @@
abbrev-js
agent
are-we-there-yet
benchmarks
bin-links
cacache
cli
cmd-shim
create-oss
disparity-colors
documentation
eslint-config
fs
fs-minipass
gauge
git
hosted-git-info
ignore-walk
Expand Down Expand Up @@ -43,7 +37,6 @@ npm-pick-manifest
npm-profile
npm-registry-fetch
npm-user-validate
npmlog
package-json
pacote
parse-conflict-json
Expand All @@ -54,15 +47,15 @@ promzard
query
read
read-cmd-shim
read-package-json
read-package-json-fast
redact
rfcs
run-script
ssri
stafftools
statusboard
tap-nock
template-oss
types
Copy link
Contributor Author

@hashtagchris hashtagchris Nov 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the types repo may have been manually excluded the last time this file was updated, unless the repo was recently tagged npm-cli. But leaving it in doesn't change the dependency graph.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't tagged before. It's not in the cli so it won't have an effect outside this file.

unique-filename
unique-slug
validate-npm-package-name
Expand Down