bugfix: Preserve https protocol when working with git

[oldium]

This prevents changing URLs from https and git+https into git+ssh, but keeps the fall-back to git+ssh when the protocol is not specified.

The change in pacote is necessary in order to have this fully working.

References

Supersedes #5256
Blocked by npm/pacote#434
Fixes #4305
Fixes #2610

[oldium]

Hm. Tests work fine, but in reality, nothing changed (package-lock.json contains git+ssh link), possibly same as in #5256. Investigating...

[oldium]

It seems also https://github.com/npm/pacote needs the same fix

[oldium]

The pacote really needs fixing, after the fix the package-lock.json contains git+https link instead of git+ssh, but still the github:repo/project is recorded in dependencies, which is not equivalent (resolves to git+ssh). Almost there... 😁

[oldium]

Fixed, tested, should work now. The fix in pacote is necessary to have this really fully working.

[oldium]

If you want to try the patched npm by yourself, feel free to checkout the fix/git-https-full branch from my clone:

git clone -b fix/git-https-full --single-branch --depth=1 https://github.com/oldium/npm-cli.git
cd npm-cli
npm install
npm link

⚠️ Warning

Please note that npm link on Linux likely requires admin permissions unless you are using Node Version Manager (nvm) to have user installation only.

⚠️ Warning

The npm link will replace the global node_modules/npm directory by a link to the local npm-cli directory. Do not delete the npm-cli directory afterwards.

⚠️ Reverting

In order to revert, reinstall the Node.js runtime. This should replace the npm link too. On Windows even global installation uses local folder, so just delete C:\Users\<user>\AppData\Roaming\npm\node_modules\npm and global one from Program Files will be used.