[Fix Accessibility Bug] Refactor code.js to improve syntax highlighting colors #1305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpg619
changed the title
|
Isn't this the kind of thing css styles is designed to solve? Can we not set this color based on the class in css? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
This pull request introduces a new function to handle custom token styling in the
Codecomponent and refactors the existing code to utilize this new function. The most important changes include the addition of thegetCustomTokenStylefunction and the refactoring of theCodecomponent to use this function for token styling.Styling improvements:
src/mdx/code.js: Added thegetCustomTokenStylefunction to handle custom token styles based on their class names.Code refactoring:
src/mdx/code.js: Refactored theCodecomponent to use thegetCustomTokenStylefunction for determining the style of each token, simplifying the code and improving maintainability.WHY
BEFORE
AFTER