This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Incorporate worker thread id in temporary filename #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
With the addition of Worker Threads [0] in Node, multiple concurrent threads could attempt to write to the same temporary filename, given they share the same
process.pid
, and could share the same invocation count as well. This incorporates the thread id, exposed from theworker_threads
exports asthreadId
.The "main" process does not have a threadId, so
-1
is used as its id in that case, as well as in the case theworker_threads
module isn't available, such as in older versions of node.Test Plan
Added a test for normalizing the
threadId
.References
[0] https://nodejs.org/api/worker_threads.html
cc @isaacs @aeschright @padmaia @devongovett @mischnic