This repository was archived by the owner on Nov 16, 2019. It is now read-only.
track missing files #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, files were treated as negated-negated ignores. This made it fairly tricky to control whether files or .npmignore took priority when deciding whether a file should be included. With this change, files are included through a more explicit process, and any applicable ignores will trump specific files.
|
This needs to exclude the change to how npmignore/files are prioritized, and get tests, then it can land. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so we keep track of which files from the files array have actually had any matches. npm will then be able to warn about them as needed. This is part of the fix for npm/npm#8791.