Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

Buffer constructor runtime deprecation - this package emits a warning on Node 10 #60

Open
benjamingr opened this issue Mar 20, 2018 · 0 comments
Open

Buffer constructor runtime deprecation - this package emits a warning on Node 10 #60

benjamingr opened this issue Mar 20, 2018 · 0 comments

Comments

@benjamingr
Copy link

Hey,

Starting on Node 10 this package will emit deprecation warnings. See this guide on what you should do in order to migrate to Buffer.alloc/Buffer.from.

See nodejs/node#19079 for discussion around this change and why we can't make new Buffer work
@benjamingr benjamingr changed the title Buffer constructor runtime deprecation - this package breaks on Node 10 Buffer constructor runtime deprecation - this package emits a warning on Node 10 Mar 20, 2018
ChALkeR added a commit to ChALkeR/fstream that referenced this issue Mar 22, 2018
@ChALkeR
Avoid using deprecated Buffer API
1b843e8 
Use Buffer.from when it's available instead of 'new Bufer(string)'

Fixes: npm#60
Refs: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor
@ChALkeR ChALkeR mentioned this issue Mar 22, 2018
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benjamingr