Test in windows, remove coverage map, test cleanup #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
changed the title
wraithgar
approved these changes
Jun 5, 2023
wraithgar
previously approved these changes
Jun 5, 2023
lukekarrys
force-pushed
the
lk/windows-ci
branch
4 times, most recently
from
01a29f7 to
0b7d3c6
Compare
This ensures that it will only short circuit if a valid path is passed in. This commit also adds one more mocked test to ensure that the system root path is always checked as the last path and no path is checked twice.
This was referenced Jun 5, 2023
wraithgar
approved these changes
Jun 6, 2023
wraithgar
approved these changes
Jun 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.