fix: break up greedy host fragment parsing regex #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a v6 backport of #274 |
wraithgar
force-pushed
the
gar/backport-host-fragment
branch
2 times, most recently
from
0396d52 to
ca7ca83
Compare
|
#278 will be needed for CI to go green |
reggi
approved these changes
Nov 21, 2024
It's easier to reason about each step this way, and also not susceptible to redos.
wraithgar
force-pushed
the
gar/backport-host-fragment
branch
from
ca7ca83 to
a4ab4a3
Compare
Merged
wraithgar
pushed a commit
that referenced
this pull request
Nov 21, 2024
🤖 I have created a release *beep* *boop* --- ## [6.1.2](v6.1.1...v6.1.2) (2024-11-21) ### Bug Fixes * [`09061c0`](09061c0) [#276](#276) break up greedy host fragment parsing regex (#276) (@wraithgar) ### Chores * [`3d8f14e`](3d8f14e) [#278](#278) bump @npmcli/template-oss from 4.7.1 to 4.23.4 (#278) (@dependabot[bot], @wraithgar) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's easier to reason about each step this way, and also not susceptible to redos.