Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cannot read property replace of null #36

Closed
wants to merge 1 commit into from
Closed

Fix Cannot read property replace of null #36

wants to merge 1 commit into from

Conversation

Erveon
Copy link
Contributor

@Erveon Erveon commented Jul 7, 2018

No description provided.

@Erveon Erveon mentioned this pull request Jul 7, 2018
Closed
iarna
iarna approved these changes Jul 7, 2018
View reviewed changes
Copy link
Contributor

@iarna iarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take this in a moment w/ the parens extra parens removed.

@iarna
Copy link
Contributor

iarna commented Jul 7, 2018

I've also added a test.

@Erveon
Copy link
Contributor Author

Erveon commented Jul 7, 2018

Changes have been merged. Thank you.

@Erveon Erveon closed this Jul 7, 2018
@iarna
Copy link
Contributor

iarna commented Jul 7, 2018 •
edited
Loading

Merged as c931482 and landed in 2.7.1

@cdaringe
Copy link

cdaringe commented Jul 7, 2018

nice! glad to find this! was coming to see if someone hadn't already landed such a PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iarna iarna iarna approved these changes

@kriswill kriswill kriswill approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Erveon @iarna @cdaringe @kriswill