fix: handling of nested unignores #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohd-akram
changed the title
|
Good catch, and a good implementation. |
wraithgar
approved these changes
Nov 29, 2023
Merged
wraithgar
pushed a commit
that referenced
this pull request
Nov 29, 2023
The fix in #116 was not quite complete. git does allow unignoring directories as long as its path to the root is unignored. This modifies the check to handle this case. The test case in `nested-ignores.js` was indeed wrong because it interpreted unignoring a specific file `!/h/c/d/hcd` as unignoring the directory `!/h/c/d`. I added new tests that specifically unignore a directory and therefore allow unignoring anything else within it. ## References Related to #116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #116 was not quite complete. git does allow unignoring directories as long as its path to the root is unignored. This modifies the check to handle this case. The test case in
nested-ignores.jswas indeed wrong because it interpreted unignoring a specific file!/h/c/d/hcdas unignoring the directory!/h/c/d. I added new tests that specifically unignore a directory and therefore allow unignoring anything else within it.References
Related to #116