This repository has been archived by the owner on May 10, 2021. It is now read-only.
chore(dirPacker): add dirPacker to options #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiahdz
added a commit
that referenced
this pull request
Oct 8, 2019
- add dirPacker to options - set dirPacker to null on lifecycle options PR-URL: #4 Credit: @claudiahdz Close: #4 Reviewed-by: @isaacs
claudiahdz
added a commit
that referenced
this pull request
Oct 8, 2019
- add dirPacker to options - set dirPacker to null on lifecycle options PR-URL: #4 Credit: @claudiahdz Close: #4 Reviewed-by: @isaacs
claudiahdz
added a commit
that referenced
this pull request
Oct 9, 2019
- add dirPacker to options - set dirPacker to null on lifecycle options PR-URL: #4 Credit: @claudiahdz Close: #4 Reviewed-by: @isaacs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✏️ Changes
This PR adds a test to make sure dirPacker is correctly defined on extract and ensures no functions are passed to lifecycle options.
🔗 References
See: npm/cli#252
Fixes: https://npm.community/t/npm-6-11-2-npm-ci-not-copying-prepared-files/9718
🔍 Testing
Automated testing
✅ This change has unit test coverage