-
Notifications
You must be signed in to change notification settings - Fork 492
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
More in line with specification at http://semver.org
- Loading branch information
Showing
3 changed files
with
20 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f676f5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3f676f5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Saw that this version of semver is used in npm 2.x – which results in eg. many sites using Grunt devDependencies breaking as some big Grunt packages moved to
^0.4.0
for their Grunt peerDependency (like grunt-contrib-uglify) when^
was introduced rather than keeping with~0.4.0
.Broken peer dependencies means that eg. all
npm install
attempts will fail – even when trying to install new unrelated dependencies.Therefore this change needs to be very clearly documented and communicated – eg in the release notes of npm 2.x – so that the affected packages can update their dependencies to this more strict standard.
3f676f5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please post comments on #92 instead of here? Commit comments are less likely to be seen by as many people.