[BUG] the package isn't compatible with Rollup due to require cycle

[thorn0]

What / Why

Rollup breaks this package when bundling it.

When

Since 2021-07-05 when @rollup/plugin-commonjs 19.0.0 has been released.

How

Current Behavior

semver.satisfies always returns false after bundling with Rollup.

Steps to Reproduce

• Clone https://github.com/thorn0/rollup-commonjs-semver-issue and install the dependencies.
• Try running unbundled input.js. It works correctly.
• Try running bundled output.js. Its output is incorrect.
• You can perform the bundling yourself by running index.mjs.

Expected Behavior

Bundled and unbundled code should work the same way.

References

• commonjs: v19.0.0 breaks semver package rollup/plugins#879
• There is a solution proposed in commonjs: v19.0.0 breaks semver package rollup/plugins#879 (comment)
• [BUG] Circular Dependency between comparator.js and range.js #318

[aurelhann]

Any news or working workaround ?

[ljharb]

Sounds like you need to file a bug on rollup then?

[Idered]

Importing one by one fixed this for me:

import maxSatisfying from "semver/ranges/max-satisfying";
import minSatisfying from "semver/ranges/min-satisfying";
import coerce from "semver/functions/coerce";

[himanshusinghs]

Facing the issue when trying to rollup a fastify server which depends on this package. If what @Idered mentioned is correct then I suppose the fix has to go to the packages that depends on semver, fastify in my case? Does anyone have more insight on what is going wrong?

[hadfieldn]

Ran into this issue today. Not a blocker for us but it would be nice to eliminate the cycle warning. Wondering if the solution proposed by @lukastaegert has been considered/attempted? (It doesn't appear that it has.)

I suppose the main issue is creating a breaking change for third-party code that imports Range and Comparator. Unfortunately I'm not familiar enough with this library yet to know what that impact would likely be, and what the workarounds might be.