- 
                Notifications
    
You must be signed in to change notification settings  - Fork 545
 
Allow piping into semver to read versions #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
    
  
     Closed
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            5 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      1a791f2
              
                patch for #149
              
              
                richardgarnier 0841679
              
                test patch for #149
              
              
                richardgarnier e63742a
              
                fixed testing for lower versions of node
              
              
                richardgarnier d4ca6fb
              
                test fixed for all versions
              
              
                richardgarnier d149eb4
              
                proceed to check the version of node
              
              
                richardgarnier File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| var test = require('tap').test; | ||
| var execSync = require('child_process').execSync | ||
| var exec = require('child_process').exec; | ||
| 
     | 
||
| test('the command line using pipes or arguments produces the same output', function (t) { | ||
| if (process.version.substring(0,5) === 'v0.10' || process.version.substring(0,5) === 'v0.12') { | ||
| t.plan(6); | ||
| var bin = 'node ./bin/semver '; | ||
| [[bin+'-i 1.0.0', 'echo 1.0.0 | '+bin+'-i'], | ||
| [bin+'-i major 1.0.0', 'echo 1.0.0 | '+bin+'-i major'], | ||
| [bin+'-i prerelease 1.0.0', 'echo 1.0.0 | '+bin+'-i prerelease'], | ||
| [bin+'-i preminor 1.0.0', 'echo 1.0.0 | '+bin+'-i preminor'], | ||
| [bin+'-i prepatch --preid alpha 1.0.0', 'echo 1.0.0 | '+bin+'-i prepatch --preid alpha'], | ||
| [bin+'-r \\>1.0.0 0.8.0 1.1.1', 'echo 0.8.0 1.1.1 | '+bin+'-r \\>1.0.0'] | ||
| ].forEach(function(tab) { | ||
| exec(tab[0], function(error, stdout, stderr) { | ||
| var resCli = stdout + stderr; | ||
| exec(tab[1], function(error, stdout, stderr) { | ||
| var resPipe = stdout + stderr; | ||
| t.assert(resCli === resPipe); | ||
| }); | ||
| }); | ||
| }); | ||
| } else { | ||
| var bin = 'node ./bin/semver '; | ||
| [[bin+'-i 1.0.0', 'echo 1.0.0 | '+bin+'-i'], | ||
| [bin+'-i major 1.0.0', 'echo 1.0.0 | '+bin+'-i major'], | ||
| [bin+'-i prerelease 1.0.0', 'echo 1.0.0 | '+bin+'-i prerelease'], | ||
| [bin+'-i preminor 1.0.0', 'echo 1.0.0 | '+bin+'-i preminor'], | ||
| [bin+'-i prepatch --preid alpha 1.0.0', 'echo 1.0.0 | '+bin+'-i prepatch --preid alpha'], | ||
| [bin+'-r \\>1.0.0 0.8.0 1.1.1', 'echo 0.8.0 1.1.1 | '+bin+'-r \\>1.0.0'] | ||
| ].forEach(function(tab) { | ||
| var resCli = execSync(tab[0]); | ||
| var resPipe = execSync(tab[1]); | ||
| t.assert(resCli.equals(resPipe)); | ||
| }); | ||
| t.end(); | ||
| } | ||
| }) | 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the break here was missing. This is not the main purpose of the patch though.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A break isn't strictly necessary here, since the
returnis just as effective at ending the block. But if a linter or something is complaining about it, whatever.