-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reuse comparators on subset #537
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think this overlaps with #538 in any way but am making a note to myself to triple check. |
H4ad
force-pushed
the
fix/reuse-subset-comparators
branch
from
April 7, 2023 00:07
f7f3f4b
to
7ecc0db
Compare
ljharb
reviewed
Apr 7, 2023
H4ad
force-pushed
the
fix/reuse-subset-comparators
branch
from
April 7, 2023 17:33
7ecc0db
to
ec94d56
Compare
wraithgar
approved these changes
Apr 10, 2023
This is a tiny startup tradeoff for a larger runtime improvement. |
nlf
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick and easy win, lgtm
Merged
This was referenced Jul 31, 2023
This was referenced May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I comment here: #528 (comment)
The method of subset was creating comparators without needing for a specific ranges, perf:
After caching those comparators:
It's an improvement of about 13~14% for these cases.
benchmark.js
About memory
To test the memory usage, I used isitfast which still in beta but provide a useful way of measuring memory (ignore op/s):
After:
Is a reduction of 21%~26% in memory usage.
isitfast.js
References