Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set max lengths in regex for numeric and build identifiers #571

Merged
merged 1 commit into from
Jun 22, 2023

Conversation

lukekarrys
Copy link
Contributor

No description provided.

@lukekarrys lukekarrys requested a review from a team as a code owner June 22, 2023 19:38
@lukekarrys lukekarrys merged commit abdd93d into main Jun 22, 2023
@lukekarrys lukekarrys deleted the lk/safe-component-regex branch June 22, 2023 20:06
@github-actions github-actions bot mentioned this pull request Jun 22, 2023
@ob1
Copy link

ob1 commented Jul 2, 2023

Hi :)
I think this introduced the bug described at #580 - would appreciate you taking a look 🙏

@Gornator Gornator mentioned this pull request Jul 2, 2023
1 task
@lukekarrys
Copy link
Contributor Author

Thanks for the issue @ob1. I've got a fix for that now in #583.

vanbasten17 pushed a commit to hubtype/botonic that referenced this pull request Aug 5, 2023
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade semver from
7.5.2 to 7.5.3.</h3>

:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>

- The recommended version is **1 version** ahead of your current
version.
- The recommended version was released **a month ago**, on 2023-06-22.


<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>semver</b></summary>
    <ul>
      <li>
<b>7.5.3</b> - <a
href="https://snyk.io/redirect/github/npm/node-semver/releases/tag/v7.5.3">2023-06-22</a></br><h2><a
href="https://snyk.io/redirect/github/npm/node-semver/compare/v7.5.2...v7.5.3">7.5.3</a>
(2023-06-22)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><a
href="https://snyk.io/redirect/github/npm/node-semver/commit/abdd93d55496d22e3c15a454a5cf13f101e48bce"><code>abdd93d</code></a>
<a href="https://snyk.io/redirect/github/npm/node-semver/pull/571"
data-hovercard-type="pull_request"
data-hovercard-url="/npm/node-semver/pull/571/hovercard">#571</a> set
max lengths in regex for numeric and build identifiers (<a
class="issue-link js-issue-link" data-error-text="Failed to load title"
data-id="1770283620" data-permission-text="Title is private"
data-url="npm/node-semver#571"
data-hovercard-type="pull_request"
data-hovercard-url="/npm/node-semver/pull/571/hovercard"
href="https://snyk.io/redirect/github/npm/node-semver/pull/571">#571</a>)
(<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/lukekarrys/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/lukekarrys">@ lukekarrys</a>)</li>
</ul>
<h3>Documentation</h3>
<ul>
<li><a
href="https://snyk.io/redirect/github/npm/node-semver/commit/bf53dd8da15a17eb6b8111115d0d8ef341fea5db"><code>bf53dd8</code></a>
<a href="https://snyk.io/redirect/github/npm/node-semver/pull/569"
data-hovercard-type="pull_request"
data-hovercard-url="/npm/node-semver/pull/569/hovercard">#569</a> add
example for <code>&gt;</code> comparator (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1760207342" data-permission-text="Title is private"
data-url="npm/node-semver#569"
data-hovercard-type="pull_request"
data-hovercard-url="/npm/node-semver/pull/569/hovercard"
href="https://snyk.io/redirect/github/npm/node-semver/pull/569">#569</a>)
(<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/mbtools/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/mbtools">@ mbtools</a>)</li>
</ul>
      </li>
      <li>
<b>7.5.2</b> - <a
href="https://snyk.io/redirect/github/npm/node-semver/releases/tag/v7.5.2">2023-06-15</a></br><h2><a
href="https://snyk.io/redirect/github/npm/node-semver/compare/v7.5.1...v7.5.2">7.5.2</a>
(2023-06-15)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><a
href="https://snyk.io/redirect/github/npm/node-semver/commit/58c791f40ba8cf4be35a5ca6644353ecd6249edc"><code>58c791f</code></a>
<a href="https://snyk.io/redirect/github/npm/node-semver/pull/566"
data-hovercard-type="pull_request"
data-hovercard-url="/npm/node-semver/pull/566/hovercard">#566</a> diff
when detecting major change from prerelease (<a class="issue-link
js-issue-link" data-error-text="Failed to load title"
data-id="1759184862" data-permission-text="Title is private"
data-url="npm/node-semver#566"
data-hovercard-type="pull_request"
data-hovercard-url="/npm/node-semver/pull/566/hovercard"
href="https://snyk.io/redirect/github/npm/node-semver/pull/566">#566</a>)
(<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/lukekarrys/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/lukekarrys">@ lukekarrys</a>)</li>
<li><a
href="https://snyk.io/redirect/github/npm/node-semver/commit/5c8efbcb3c6c125af10746d054faff13e8c33fbd"><code>5c8efbc</code></a>
<a href="https://snyk.io/redirect/github/npm/node-semver/pull/565"
data-hovercard-type="pull_request"
data-hovercard-url="/npm/node-semver/pull/565/hovercard">#565</a>
preserve build in raw after inc (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1758105410"
data-permission-text="Title is private"
data-url="npm/node-semver#565"
data-hovercard-type="pull_request"
data-hovercard-url="/npm/node-semver/pull/565/hovercard"
href="https://snyk.io/redirect/github/npm/node-semver/pull/565">#565</a>)
(<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/lukekarrys/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/lukekarrys">@ lukekarrys</a>)</li>
<li><a
href="https://snyk.io/redirect/github/npm/node-semver/commit/717534ee353682f3bcf33e60a8af4292626d4441"><code>717534e</code></a>
<a href="https://snyk.io/redirect/github/npm/node-semver/pull/564"
data-hovercard-type="pull_request"
data-hovercard-url="/npm/node-semver/pull/564/hovercard">#564</a> better
handling of whitespace (<a class="issue-link js-issue-link"
data-error-text="Failed to load title" data-id="1757995222"
data-permission-text="Title is private"
data-url="npm/node-semver#564"
data-hovercard-type="pull_request"
data-hovercard-url="/npm/node-semver/pull/564/hovercard"
href="https://snyk.io/redirect/github/npm/node-semver/pull/564">#564</a>)
(<a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/lukekarrys/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://snyk.io/redirect/github/lukekarrys">@ lukekarrys</a>)</li>
</ul>
      </li>
    </ul>
from <a
href="https://snyk.io/redirect/github/npm/node-semver/releases">semver
GitHub release notes</a>
  </details>
</details>


<details>
  <summary><b>Commit messages</b></summary>
  </br>
  <details>
    <summary>Package name: <b>semver</b></summary>
    <ul>
<li><a
href="https://snyk.io/redirect/github/npm/node-semver/commit/7fdf1ef223826b428d7f8aaf906e9eeefa9469f9">7fdf1ef</a>
chore: release 7.5.3</li>
<li><a
href="https://snyk.io/redirect/github/npm/node-semver/commit/bf53dd8da15a17eb6b8111115d0d8ef341fea5db">bf53dd8</a>
docs: add example for &#x60;&gt;&#x60; comparator (#569)</li>
<li><a
href="https://snyk.io/redirect/github/npm/node-semver/commit/abdd93d55496d22e3c15a454a5cf13f101e48bce">abdd93d</a>
fix: set max lengths in regex for numeric and build identifiers
(#571)</li>
    </ul>

<a
href="https://snyk.io/redirect/github/npm/node-semver/compare/e7b78de06eb14a7fa2075cedf9f167040d8d31af...7fdf1ef223826b428d7f8aaf906e9eeefa9469f9">Compare</a>
  </details>
</details>
<hr/>

**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*

For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJiMWEyMTY5MS04NWI3LTQ1MjMtOWM5ZS1hYjU3OTdjOWFkZDciLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImIxYTIxNjkxLTg1YjctNDUyMy05YzllLWFiNTc5N2M5YWRkNyJ9fQ=="
width="0" height="0"/>

🧐 [View latest project
report](https://app.snyk.io/org/manuelfidalgo/project/1e476a2c-f968-4574-8a48-a93a0982eecc?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/manuelfidalgo/project/1e476a2c-f968-4574-8a48-a93a0982eecc/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/manuelfidalgo/project/1e476a2c-f968-4574-8a48-a93a0982eecc/settings/integration?pkg&#x3D;semver&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

<!---
(snyk:metadata:{"prId":"b1a21691-85b7-4523-9c9e-ab5797c9add7","prPublicId":"b1a21691-85b7-4523-9c9e-ab5797c9add7","dependencies":[{"name":"semver","from":"7.5.2","to":"7.5.3"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/manuelfidalgo/project/1e476a2c-f968-4574-8a48-a93a0982eecc?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"1e476a2c-f968-4574-8a48-a93a0982eecc","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2023-06-22T21:53:19.774Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->

Co-authored-by: snyk-bot <snyk-bot@snyk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants