Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better handling of whitespace (backport to v6) #591

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fix: better handling of whitespace (backport to v6) #591

merged 1 commit into from
Jul 10, 2023

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Jul 7, 2023 •
edited
Loading

This is a backport of the following commits squashed to land on
release/v6:

Ref: #564

@lukekarrys @joaomoreno
fix: better handling of whitespace
0962ab9 
This is a backport of the following commits squashed to land on
`release/v6`:

- 717534e
- abdd93d
- cc6fde2
- 99d8287

Ref: #564

Co-authored-by: joaomoreno <mail@joaomoreno.com>
@lukekarrys lukekarrys requested a review from a team as a code owner July 7, 2023 22:52
@lukekarrys lukekarrys changed the title fix: better handling of whitespace fix: better handling of whitespace (backport to v6) Jul 7, 2023
@lukekarrys
Copy link
Contributor Author

@nicolo-ribaudo I was able to get the backport from v5 to land on v6 without much trouble. How does this look compared to what you did in your fork?

@lukekarrys lukekarrys mentioned this pull request Jul 7, 2023
Closed
1 task
nicolo-ribaudo
nicolo-ribaudo reviewed Jul 10, 2023
View reviewed changes
Copy link

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very similar to my own backport 👍

@david-luna david-luna mentioned this pull request Jul 10, 2023
Closed
@lukekarrys lukekarrys merged commit 928e56d into release/v6 Jul 10, 2023
@lukekarrys lukekarrys deleted the lk/v6-backport branch July 10, 2023 19:07
@github-actions github-actions bot mentioned this pull request Jul 10, 2023
Merged
@Logan0112

This comment was marked as spam.

Sign in to view
@aadhar-agarwal aadhar-agarwal mentioned this pull request Aug 17, 2023
Open
@WontonSam WontonSam mentioned this pull request Jul 16, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jul 18, 2024
Open
@WontonSam WontonSam mentioned this pull request Jul 21, 2024
Open
@q1blue q1blue mentioned this pull request Jul 28, 2024
Open
@WontonSam WontonSam mentioned this pull request Aug 8, 2024
Open
@Ramyromel Ramyromel mentioned this pull request Aug 10, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Aug 21, 2024
Open
@bhaarneval bhaarneval mentioned this pull request Sep 6, 2024
Open
@Ganjahmanvenenodedios Ganjahmanvenenodedios mentioned this pull request Sep 7, 2024
Open
@bhaarneval bhaarneval mentioned this pull request Sep 8, 2024
Open
@Ganjahmanvenenodedios Ganjahmanvenenodedios mentioned this pull request Sep 9, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request Sep 9, 2024
Open
@WontonSam WontonSam mentioned this pull request Sep 9, 2024
Open
@bhaarneval bhaarneval mentioned this pull request Sep 12, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request Sep 12, 2024
Open
This was referenced Sep 13, 2024
Open
Open
This was referenced Sep 13, 2024
Open
Open
This was referenced Sep 16, 2024
Open
Open
Open
@nerds-github nerds-github mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo left review comments

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukekarrys @Logan0112 @wraithgar @nicolo-ribaudo