Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add bun.lockb to ignorelist #168

Merged
merged 1 commit into from
Nov 25, 2024
Merged

feat: add bun.lockb to ignorelist #168

merged 1 commit into from
Nov 25, 2024

Conversation

antongolub
Copy link
Contributor

@antongolub antongolub commented May 1, 2023 •
edited by wraithgar
Loading

BREAKING CHANGE: this adds bun.lockb to the strict ignorelist

@antongolub antongolub requested a review from a team as a code owner May 1, 2023 21:02
@antongolub antongolub requested review from nlf and removed request for a team May 1, 2023 21:02
@wraithgar
Copy link
Member

The reason that didn't get implemented is likely due more to the fact that it was a breaking change that got lost in the npm@7 timeline than anything else.

A change like this would bubble up as a breaking change all the way up to npm itself, and would need to be coordinated with the next semver major of npm.

@wraithgar
Copy link
Member

I added #48 to the v10 roadmap to see if this is something we want to finally do

@ljharb
Copy link

ljharb commented May 1, 2023

Are people using bun with packages all that much? I thought it was for apps.

@wraithgar
Copy link
Member

changing the scope of ignored files was moved out of scope of npm 10 so that it could land eventually in node 18's main branch (which it has now!). This will have to wait till npm 11.

@wraithgar wraithgar mentioned this pull request Sep 25, 2024
Open
@Jarred-Sumner
Copy link

I suggest adding bun.lock to this list as well.

@wraithgar
Copy link
Member

wraithgar commented Nov 25, 2024 •
edited
Loading

Looking at https://bun.sh/docs/install/lockfile, it does not look like bun.lock is a real thing

@wraithgar wraithgar merged commit 9f74fd3 into npm:main Nov 25, 2024
@github-actions github-actions bot mentioned this pull request Nov 25, 2024
Merged
@ljharb
Copy link

ljharb commented Nov 25, 2024 •
edited
Loading

@wraithgar I assume that the creator of bun meant, that it will be a real thing in the future and it'd be wise to ignore it now.

wraithgar pushed a commit that referenced this pull request Nov 25, 2024
@github-actions
chore: release 10.0.0 (#253)
b50e3c4 
🤖 I have created a release *beep* *boop*
---


##
[10.0.0](v9.0.0...v10.0.0)
(2024-11-25)
### ⚠️ BREAKING CHANGES
* this module is now compatible with the following node versions:
^20.17.0 || >=22.9.0
* `bun.lockb` is now included in the strict ignorelist
### Features
*
[`9f74fd3`](9f74fd3)
[#168](#168) add `bun.lockb` to
ignorelist (#168) (@antongolub)
### Bug Fixes
*
[`67fef03`](67fef03)
update engines to ^20.17.0 || >=22.9.0 (#254) (@wraithgar)
### Chores
*
[`fd425fa`](fd425fa)
bump @npmcli/eslint-config from 4.0.5 to 5.0.1 (#250) (@dependabot[bot])
*
[`3b66b5a`](3b66b5a)
[#252](#252) bump
@npmcli/arborist from 7.5.4 to 8.0.0 (#252) (@dependabot[bot])
*
[`e688d26`](e688d26)
bump @npmcli/template-oss from 4.23.3 to 4.23.4 (#251)
(@dependabot[bot], @npm-cli-bot)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

@nlf nlf Awaiting requested review from nlf nlf is a code owner automatically assigned from npm/cli-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@antongolub @wraithgar @ljharb @Jarred-Sumner