Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Isaacs/do not force include so much stuff #61

Merged
merged 2 commits into from
May 5, 2021
Merged

Isaacs/do not force include so much stuff #61

merged 2 commits into from
May 5, 2021

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented May 5, 2021

References

@isaacs isaacs force-pushed the isaacs/do-not-force-include-so-much-stuff branch from e765132 to 32983b9 Compare May 5, 2021 17:24
isaacs added 2 commits May 5, 2021 12:11
@isaacs
Add test to verify some other files always included
9d58723
@isaacs
Do not force include history, changelogs, notice
2b29fc2 
Only forcibly include the files that are load-bearing by the npm
registry

PR-URL: #61
Credit: @isaacs
Close: #61
Reviewed-by: @nlf
@isaacs isaacs force-pushed the isaacs/do-not-force-include-so-much-stuff branch from 32983b9 to 2b29fc2 Compare May 5, 2021 19:11
@isaacs isaacs closed this in 2b29fc2 May 5, 2021
@isaacs isaacs merged commit 2b29fc2 into main May 5, 2021
@hanazuki hanazuki mentioned this pull request May 30, 2021
Open
1 task
@akijoey akijoey mentioned this pull request Aug 7, 2021
Closed
matz3 added a commit to SAP/ui5-cli that referenced this pull request Jan 28, 2022
@matz3
[INTERNAL] npm release: Add missing CHANGELOG file
04d2902 
The CLI needs the changelog files of all modules to create a
consolidated changelog.

Since npm v7 the CHANGELOG file is not always published anymore.
See: npm/npm-packlist#61
@matz3 matz3 mentioned this pull request Jan 28, 2022
Merged
matz3 added a commit to SAP/ui5-builder that referenced this pull request Jan 28, 2022
@matz3
[INTERNAL] npm release: Add missing CHANGELOG file
094ca4a 
The CLI needs the changelog files of all modules to create a
consolidated changelog.

Since npm v7 the CHANGELOG file is not always published anymore.
See: npm/npm-packlist#61
@matz3 matz3 mentioned this pull request Jan 28, 2022
Merged
matz3 added a commit to SAP/ui5-server that referenced this pull request Jan 28, 2022
@matz3
[INTERNAL] npm release: Add missing CHANGELOG file
7c2bc46 
The CLI needs the changelog files of all modules to create a
consolidated changelog.

Since npm v7 the CHANGELOG file is not always published anymore.
See: npm/npm-packlist#61
@matz3 matz3 mentioned this pull request Jan 28, 2022
Merged
matz3 added a commit to SAP/ui5-project that referenced this pull request Jan 28, 2022
@matz3
[INTERNAL] npm release: Add missing CHANGELOG file
d1e11e8 
The CLI needs the changelog files of all modules to create a
consolidated changelog.

Since npm v7 the CHANGELOG file is not always published anymore.
See: npm/npm-packlist#61
@matz3 matz3 mentioned this pull request Jan 28, 2022
Merged
matz3 added a commit to SAP/ui5-fs that referenced this pull request Jan 28, 2022
@matz3
[INTERNAL] npm release: Add missing CHANGELOG file
e0cdaa3 
The CLI needs the changelog files of all modules to create a
consolidated changelog.

Since npm v7 the CHANGELOG file is not always published anymore.
See: npm/npm-packlist#61
@matz3 matz3 mentioned this pull request Jan 28, 2022
Merged
matz3 added a commit to SAP/ui5-logger that referenced this pull request Jan 28, 2022
@matz3
[INTERNAL] npm release: Add missing CHANGELOG file
1c17398 
The CLI needs the changelog files of all modules to create a
consolidated changelog.

Since npm v7 the CHANGELOG file is not always published anymore.
See: npm/npm-packlist#61
@matz3 matz3 mentioned this pull request Jan 28, 2022
Merged
matz3 added a commit to SAP/ui5-builder that referenced this pull request Jan 31, 2022
@matz3
[INTERNAL] npm release: Add missing CHANGELOG file
034dd43 
The CLI needs the changelog files of all modules to create a
consolidated changelog.

Since npm v7 the CHANGELOG file is not always published anymore.
See: npm/npm-packlist#61
matz3 added a commit to SAP/ui5-project that referenced this pull request Jan 31, 2022
@matz3
[INTERNAL] npm release: Add missing CHANGELOG file
0072815 
The CLI needs the changelog files of all modules to create a
consolidated changelog.

Since npm v7 the CHANGELOG file is not always published anymore.
See: npm/npm-packlist#61
matz3 added a commit to SAP/ui5-fs that referenced this pull request Jan 31, 2022
@matz3
[INTERNAL] npm release: Add missing CHANGELOG file
1e0120d 
The CLI needs the changelog files of all modules to create a
consolidated changelog.

Since npm v7 the CHANGELOG file is not always published anymore.
See: npm/npm-packlist#61
matz3 added a commit to SAP/ui5-server that referenced this pull request Jan 31, 2022
@matz3
[INTERNAL] npm release: Add missing CHANGELOG file
8651039 
The CLI needs the changelog files of all modules to create a
consolidated changelog.

Since npm v7 the CHANGELOG file is not always published anymore.
See: npm/npm-packlist#61
matz3 added a commit to SAP/ui5-logger that referenced this pull request Jan 31, 2022
@matz3
[INTERNAL] npm release: Add missing CHANGELOG file
a79ea5f 
The CLI needs the changelog files of all modules to create a
consolidated changelog.

Since npm v7 the CHANGELOG file is not always published anymore.
See: npm/npm-packlist#61
matz3 added a commit to SAP/ui5-cli that referenced this pull request Jan 31, 2022
@matz3
[INTERNAL] npm release: Add missing CHANGELOG file
735bad8 
The CLI needs the changelog files of all modules to create a
consolidated changelog.

Since npm v7 the CHANGELOG file is not always published anymore.
See: npm/npm-packlist#61
@wraithgar wraithgar deleted the isaacs/do-not-force-include-so-much-stuff branch December 1, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isaacs @nlf