normalize #30
Closed
normalize #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
commented
May 9, 2023
| this[_filename] = resolve(path, 'package.json') | ||
| this[_manifest] = {} | ||
| this[_readFileContent] = '' | ||
| this.#path = path |
There was a problem hiding this comment.
the read-package-json code will need this
|
Need to come up with a better name than One is intended for reading from node_modules in a tree, one is intended for reading before publishing. |
|
Maybe |
This brings in parity with `read-package-json-fast`, which is a normalization method intended for parsing package.json files inside of an existing node_modules. Tests were copied straight from that package to ensure functionality was compatible. The only tests that weren't copied were the ones testing down into the bin normalization. That is delegated to a subdependency so these tests only ensure that *some* normalization is happening. Eventually as we consolidate our package.json reading libs, bin normalization can live in this package and be tested here. Finally, the errors that this package was throwing now include the metadata from the original errors (such as code) instead of making new errors with no context.
|
#32 will be where this lands. One more fix to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits here, one deps and one feat. Please rebase to merge.
This brings in parity with
read-package-json-fast, which is anormalization method intended for parsing package.json files inside of
an existing node_modules.
Tests were copied straight from that package to ensure functionality was
compatible. The only tests that weren't copied were the ones testing
down into the bin normalization. That is delegated to a subdependency so
these tests only ensure that some normalization is happening.
Eventually as we consolidate our package.json reading libs, bin
normalization can live in this package and be tested here.
Finally, the errors that this package was throwing now include the
metadata from the original errors (such as code) instead of making new
errors with no context.