deps: replace node builtin rmSync with rimraf #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
wraithgar
reviewed
Nov 22, 2024
|
Add that comment and I'll land this. |
Co-authored-by: Gar <wraithgar@github.com>
wraithgar
approved these changes
Nov 25, 2024
wraithgar
changed the title
Merged
|
This should have been a Ah well. |
wraithgar
pushed a commit
that referenced
this pull request
Nov 25, 2024
🤖 I have created a release *beep* *boop* --- ## [21.0.0](v20.0.0...v21.0.0) (2024-11-25) ###⚠️ BREAKING CHANGES * `bun.lockb` files are now included in the strict ignore list during packing * this module is now compatible with the following node versions: ^20.17.0 || >=22.9.0 ### Bug Fixes * [`844dc08`](844dc08) update node engines to ^20.17.0 || >=22.9.0 (#414) (@wraithgar) ### Dependencies * [`2cb6fa7`](2cb6fa7) [#415](#415) `npm-packlist@10.0.0` (#415) * [`47b928c`](47b928c) [#412](#412) replace node builtin rmSync with rimraf (#412) (@mbtools) ### Chores * [`b6f35a2`](b6f35a2) [#402](#402) bump @npmcli/arborist from 7.5.4 to 8.0.0 (#402) (@dependabot[bot]) * [`1ef54ba`](1ef54ba) [#408](#408) support tests on win32 (#408) (@mbtools) * [`555b000`](555b000) [#401](#401) bump @npmcli/template-oss from 4.23.3 to 4.23.4 (#401) (@dependabot[bot], @npm-cli-bot) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the EBUSY issue during "spawn daemon" test mentioned in #408