Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite #77

Merged
merged 6 commits into from
Apr 12, 2024
Merged

Rewrite #77

merged 6 commits into from
Apr 12, 2024

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Apr 11, 2024 •
edited
Loading

This is a rewrite of proc-log

  • feat!: change current exported function "log"
    Everything that's currently in proc-log is now exported as a log object
  • fix(refactor): don't loop through levels to generate log export
    The entire module is inline, no loops. Tests ensure that we are synced between levels and methods.
  • feat(log): add timing log level
    A new timing log level has been added
  • feat: add output methods
    A new output export has been added with three levels: standard, error, and buffer. It works exactly like the log object but emits output events.
  • fix: switch to traditional functions
    They are marginally faster and this is potentially a pretty hot path.

@wraithgar
feat!: change current exported function "log"
0ad1e5f 
BREAKING CHANGE: the exports on this package have changed.  The current
functionality has moved to a `log` function in the exports.
@wraithgar
fix(refactor): don't loop through levels to generate log export
e46bfe5 
Instead use a test to make sure LEVELS an functions match
@wraithgar
feat(log): add timing log level
6f7f5ff
@wraithgar wraithgar requested a review from a team as a code owner April 11, 2024 17:04
@wraithgar wraithgar force-pushed the gar/export-and-timing branch 2 times, most recently from f934810 to d7bd49f Compare April 11, 2024 17:09
lukekarrys
lukekarrys reviewed Apr 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
test/index.js Outdated Show resolved Hide resolved
@wraithgar wraithgar force-pushed the gar/export-and-timing branch from d7bd49f to f8071a8 Compare April 11, 2024 17:16
@wraithgar
feat: add output methods
d32f9ce
@wraithgar
fix: switch to traditional functions
d0a9a06 
They are marginally faster and this is a very hot path
@wraithgar wraithgar force-pushed the gar/export-and-timing branch from 2760428 to d0a9a06 Compare April 11, 2024 19:33
fritzy
fritzy requested changes Apr 11, 2024
View reviewed changes
test/index.js Show resolved Hide resolved
fritzy
fritzy previously approved these changes Apr 11, 2024
View reviewed changes
Copy link

@fritzy fritzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wraithgar wraithgar requested a review from fritzy April 11, 2024 21:07
@wraithgar wraithgar merged commit 3caba0e into main Apr 12, 2024
26 checks passed
@wraithgar wraithgar deleted the gar/export-and-timing branch April 12, 2024 14:06
@github-actions github-actions bot mentioned this pull request Apr 12, 2024
Merged
wraithgar pushed a commit that referenced this pull request Apr 12, 2024
@github-actions
chore: release 4.0.0 (#72)
ad99316 
🤖 I have created a release *beep* *boop*
---


## [4.0.0](v3.0.0...v4.0.0)
(2024-04-12)

### ⚠️ BREAKING CHANGES

* the exports on this package have changed. The current functionality
has moved to a `log` function in the exports.

### Features

*
[`39db1e1`](39db1e1)
[#77](#77) add output methods
(@wraithgar)
*
[`12f35fe`](12f35fe)
[#77](#77) log: add timing log level
(@wraithgar)
*
[`8e90af0`](8e90af0)
[#77](#77) change current exported
function "log" (@wraithgar)

### Bug Fixes

*
[`ac543c4`](ac543c4)
[#77](#77) switch to traditional
functions (@wraithgar)
*
[`978fbf9`](978fbf9)
[#77](#77) refactor: don't loop
through levels to generate log export (@wraithgar)

### Chores

*
[`a393ac6`](a393ac6)
[#78](#78) enable auto publish (#78)
(@wraithgar)
*
[`3caba0e`](3caba0e)
[#77](#77) add test plan count for
current methods (@wraithgar)
*
[`6442a36`](6442a36)
[#73](#73) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`f8df624`](f8df624)
[#73](#73) bump @npmcli/template-oss
from 4.21.1 to 4.21.3 (@dependabot[bot])
*
[`31491ca`](31491ca)
[#70](#70) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`be382b7`](be382b7)
[#70](#70) bump @npmcli/template-oss
from 4.19.0 to 4.21.1 (@dependabot[bot])
*
[`de668d7`](de668d7)
[#51](#51) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`4b8abd0`](4b8abd0)
[#51](#51) bump @npmcli/template-oss
from 4.18.1 to 4.19.0 (@dependabot[bot])
*
[`ed8c220`](ed8c220)
[#50](#50) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`36b1d1e`](36b1d1e)
[#50](#50) bump @npmcli/template-oss
from 4.18.0 to 4.18.1 (@dependabot[bot])
*
[`dfda484`](dfda484)
[#49](#49) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`f9a8d6d`](f9a8d6d)
[#49](#49) bump @npmcli/template-oss
from 4.17.0 to 4.18.0 (@dependabot[bot])
*
[`857d35e`](857d35e)
[#48](#48) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`6e51a61`](6e51a61)
[#48](#48) bump @npmcli/template-oss
from 4.15.1 to 4.17.0 (@dependabot[bot])
*
[`e668ec7`](e668ec7)
[#47](#47) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`eea3f85`](eea3f85)
[#47](#47) bump @npmcli/template-oss
from 4.14.1 to 4.15.1 (@dependabot[bot])
*
[`bc05709`](bc05709)
[#46](#46) bump @npmcli/template-oss
from 4.13.0 to 4.14.1 (#46) (@dependabot[bot], @npm-cli-bot)
*
[`98c7267`](98c7267)
[#45](#45) bump @npmcli/template-oss
from 4.12.1 to 4.13.0 (#45) (@dependabot[bot], @npm-cli-bot, @nlf)
*
[`3500db4`](3500db4)
[#44](#44) bump @npmcli/template-oss
from 4.12.0 to 4.12.1 (#44) (@dependabot[bot], @npm-cli-bot)
*
[`7636af5`](7636af5)
[#43](#43) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`3dc1ca0`](3dc1ca0)
[#43](#43) bump @npmcli/template-oss
from 4.11.4 to 4.12.0 (@dependabot[bot])
*
[`b62ca21`](b62ca21)
[#42](#42) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`cef0e0d`](cef0e0d)
[#42](#42) bump @npmcli/template-oss
from 4.11.3 to 4.11.4 (@dependabot[bot])
*
[`cabc576`](cabc576)
[#41](#41) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`f34b6c7`](f34b6c7)
[#41](#41) bump @npmcli/template-oss
from 4.11.0 to 4.11.3 (@dependabot[bot])
*
[`2533092`](2533092)
[#40](#40) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`bca92ea`](bca92ea)
[#40](#40) bump @npmcli/template-oss
from 4.10.0 to 4.11.0 (@dependabot[bot])
*
[`3721aed`](3721aed)
[#39](#39) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`94b7ef3`](94b7ef3)
[#39](#39) bump @npmcli/template-oss
from 4.8.0 to 4.10.0 (@dependabot[bot])
*
[`d4db1ab`](d4db1ab)
[#37](#37) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`5b16b3a`](5b16b3a)
[#37](#37) bump @npmcli/template-oss
from 4.6.2 to 4.8.0 (@dependabot[bot])
*
[`35fbba3`](35fbba3)
[#36](#36) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`1c0da10`](1c0da10)
[#36](#36) bump @npmcli/template-oss
from 4.6.1 to 4.6.2 (@dependabot[bot])
*
[`487cfeb`](487cfeb)
[#35](#35) postinstall for
dependabot template-oss PR (@lukekarrys)
*
[`70dbd12`](70dbd12)
[#35](#35) bump @npmcli/template-oss
from 4.5.1 to 4.6.1 (@dependabot[bot])
*
[`d299887`](d299887)
[#34](#34) bump
@npmcli/eslint-config from 3.1.0 to 4.0.0 (@dependabot[bot])

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@wraithgar wraithgar mentioned this pull request Apr 15, 2024
Closed
This was referenced Aug 10, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzy fritzy fritzy approved these changes

@lukekarrys lukekarrys lukekarrys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wraithgar @fritzy @lukekarrys