-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option for npm diff to ignore cr at eol #522
Conversation
Thanks for the contribution @oBusk! We chatted about it in our weekly OpenRFC calls (you're able to catch up with the recordings if you click on the linked issues here) and my feedback there is that this was the plan all along 😁 Launch with a minimal set of options enabled and let's wait for the community to surface what other options from It looks like you already got started on a PR in I believe this is ready to land. So to answer to the questions at the end:
I'd stick with
I believe they're two different things but to be honest, we're probably just going to follow the default behavior that
I don't think so, it might be very useful to have that metadata surfaced in some cases and it seems to be a more "correct" default behavior. Anyone else might opt into the option in their |
@ruyadorno that's so cool 😊 I had a look at both this and last weeks meeting and I agree with the notion of trying to keep npm diff to match git diff where possible. In the latest meeting it was mentioned a question of what the default in |
yeah, I'm assuming the same! |
An option to make
npm diff
more useful when working on packages developedacross multiple platforms.
This is my first suggestion. Please let me know if it needs clarification or
improvement!
References