RFC: Dependency Selector Syntax & npm query
#564
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnb
reviewed
Mar 30, 2022
bnb
reviewed
Mar 30, 2022
bnb
reviewed
Mar 30, 2022
bnb
reviewed
Mar 30, 2022
bnb
reviewed
Mar 30, 2022
bnb
reviewed
Mar 30, 2022
Co-authored-by: Tierney Cyren <accounts@bnb.im>
ljharb
reviewed
Mar 31, 2022
Co-authored-by: Jordan Harband <ljharb@gmail.com>
This was referenced Apr 13, 2022
This was referenced Apr 27, 2022
This was referenced May 11, 2022
…nflicts w/ new :attr()
ljharb
reviewed
May 18, 2022
Comment on lines
+37
to
+38
| - `.` class selector | ||
| - `:` pseudo class selector |
There was a problem hiding this comment.
i still think these need to be named without the word "class".
ljharb
reviewed
May 18, 2022
| #### Example of an `Object`: | ||
| ```css | ||
| /* return dependencies that have a `scripts.test` containing `"tap"` */ | ||
| *:attr(:scripts([test~=tap])) |
There was a problem hiding this comment.
would be good to add an example with a quoted key as well
| #### Example of an `Array` Attribute Selection: | ||
| ```css | ||
| /* return dependencies that have a keyword that begins with "react" */ | ||
| *:attr(:keywords([item^="react"])) |
There was a problem hiding this comment.
it'd be ideal to pick something that can't visually be confused with an object key - pretty much anything that, as an object key, would be forced to be quoted, would be a clear indicator that "keywords" is an array instead of an object
This was referenced May 25, 2022
|
It would be great to have Tab Completion on quires! [Should that also be an RFC in itself?] |
I would expect this to be a follow-up RFC and not part of the core feature RFC. |
ruyadorno
added a commit
to npm/cli
that referenced
this pull request
Jun 8, 2022
Implemented Arborist `querySelectorAll` method that enables easier retrieval of installed packages using a css-selector-like syntax. It also includes a new command `npm query` that exposes that same logic to users of the npm cli. Ref: npm/rfcs#564
ruyadorno
added a commit
to npm/cli
that referenced
this pull request
Jun 8, 2022
Implemented Arborist `querySelectorAll` method that enables easier retrieval of installed packages using a css-selector-like syntax. It also includes a new command `npm query` that exposes that same logic to users of the npm cli. Ref: npm/rfcs#564
ruyadorno
added a commit
to npm/cli
that referenced
this pull request
Jun 9, 2022
Implemented Arborist `querySelectorAll` method that enables easier retrieval of installed packages using a css-selector-like syntax. It also includes a new command `npm query` that exposes that same logic to users of the npm cli. Ref: npm/rfcs#564
wraithgar
pushed a commit
to npm/cli
that referenced
this pull request
Jun 22, 2022
Implemented Arborist `querySelectorAll` method that enables easier retrieval of installed packages using a css-selector-like syntax. It also includes a new command `npm query` that exposes that same logic to users of the npm cli. Ref: npm/rfcs#564
wraithgar
pushed a commit
to npm/cli
that referenced
this pull request
Jun 23, 2022
Implemented Arborist `querySelectorAll` method that enables easier retrieval of installed packages using a css-selector-like syntax. It also includes a new command `npm query` that exposes that same logic to users of the npm cli. Ref: npm/rfcs#564
wraithgar
pushed a commit
to npm/cli
that referenced
this pull request
Jun 23, 2022
Implemented Arborist `querySelectorAll` method that enables easier retrieval of installed packages using a css-selector-like syntax. It also includes a new command `npm query` that exposes that same logic to users of the npm cli. Ref: npm/rfcs#564
wraithgar
pushed a commit
to npm/cli
that referenced
this pull request
Jun 28, 2022
Implemented Arborist `querySelectorAll` method that enables easier retrieval of installed packages using a css-selector-like syntax. It also includes a new command `npm query` that exposes that same logic to users of the npm cli. Ref: npm/rfcs#564
wraithgar
pushed a commit
to npm/cli
that referenced
this pull request
Jul 13, 2022
Implemented Arborist `querySelectorAll` method that enables easier retrieval of installed packages using a css-selector-like syntax. It also includes a new command `npm query` that exposes that same logic to users of the npm cli. Ref: npm/rfcs#564
darcyclarke
added
ratify
and removed
Agenda
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered RFC* Updated
Overview
.querySelectorAll()method toNodes returned fromArboristnpm query