Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add safety checks and UX considerations when running as root #653

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add safety checks and UX considerations when running as root #653

wants to merge 1 commit into from

Conversation

isaacs
Copy link
Contributor

@isaacs isaacs commented Nov 11, 2022

ljharb
ljharb approved these changes Nov 13, 2022
View reviewed changes
Copy link
Contributor

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all sound great to me; the only time someone should be using sudo with npm is sudo npm install -g when they've installed node in a global place.

@DerekNonGeneric DerekNonGeneric mentioned this pull request Dec 10, 2022
Closed
@nlf
Copy link
Contributor

nlf commented Jan 5, 2023

this is great, thanks for writing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isaacs @nlf @ljharb