fix: Ignore transient tap test directories (#364)

Running tests causes a lot of file churn. Although (usually) ephemeral,
these files cause high CPU usage and can make developer tools difficult
to use. These files also make linting fail.

Now the files will be ignored by git and by eslint.

## References
Fixes #348
Fixes #359

This is a rebase of #350 since it had yet another conflict.

---------

Authored-by: Dan <DanOfTheRoses@gmail.com>

.eslintrc.js

@@ -11,6 +11,7 @@ const localConfigs = readdir(__dirname)
 module.exports = {
   root: true,
   ignorePatterns: [
+    'tap-testdir*/',
     'workspace/test-workspace/**',
   ],
   extends: [

.gitignore

@@ -2,6 +2,8 @@
 
 # ignore everything in the root
 /*
+# transient test directories
+tap-testdir*/
 
 # keep these
 !**/.gitignore

lib/content/eslintrc.js

@@ -8,13 +8,12 @@ const localConfigs = readdir(__dirname)
 
 module.exports = {
   root: true,
-  {{#if workspaceGlobs}}
   ignorePatterns: [
+    'tap-testdir*/',
     {{#each workspaceGlobs}}
     '{{ . }}',
     {{/each}}
   ],
-  {{/if}}
   extends: [
     '@npmcli',
     ...localConfigs,

lib/content/gitignore

@@ -1,5 +1,7 @@
 # ignore everything in the root
 /*
+# transient test directories
+tap-testdir*/
 
 # keep these
 {{#each ignorePaths}}

lib/content/index.js

@@ -157,7 +157,9 @@ module.exports = {
     '/LICENSE*',
     '/CHANGELOG*',
   ],
-  ignorePaths: [],
+  ignorePaths: [
+    /* to be provided by consuming package */
+  ],
   ciVersions: {},
   latestCiVersion: 20,
   lockfile: false,

tap-snapshots/test/apply/source-snapshots.js.test.cjs

@@ -33,6 +33,9 @@ const localConfigs = readdir(__dirname)
 
 module.exports = {
   root: true,
+  ignorePatterns: [
+    'tap-testdir*/',
+  ],
   extends: [
     '@npmcli',
     ...localConfigs,
@@ -1638,6 +1641,8 @@ jobs:
 
 # ignore everything in the root
 /*
+# transient test directories
+tap-testdir*/
 
 # keep these
 !**/.gitignore
@@ -1873,6 +1878,7 @@ const localConfigs = readdir(__dirname)
 module.exports = {
   root: true,
   ignorePatterns: [
+    'tap-testdir*/',
     'workspaces/a/**',
     'workspaces/b/**',
   ],
@@ -3855,6 +3861,8 @@ jobs:
 
 # ignore everything in the root
 /*
+# transient test directories
+tap-testdir*/
 
 # keep these
 !**/.gitignore
@@ -4078,6 +4086,9 @@ const localConfigs = readdir(__dirname)
 
 module.exports = {
   root: true,
+  ignorePatterns: [
+    'tap-testdir*/',
+  ],
   extends: [
     '@npmcli',
     ...localConfigs,
@@ -4090,6 +4101,8 @@ workspaces/a/.gitignore
 
 # ignore everything in the root
 /*
+# transient test directories
+tap-testdir*/
 
 # keep these
 !**/.gitignore
@@ -4153,6 +4166,9 @@ const localConfigs = readdir(__dirname)
 
 module.exports = {
   root: true,
+  ignorePatterns: [
+    'tap-testdir*/',
+  ],
   extends: [
     '@npmcli',
     ...localConfigs,
@@ -4165,6 +4181,8 @@ workspaces/b/.gitignore
 
 # ignore everything in the root
 /*
+# transient test directories
+tap-testdir*/
 
 # keep these
 !**/.gitignore
@@ -5877,6 +5895,9 @@ const localConfigs = readdir(__dirname)
 
 module.exports = {
   root: true,
+  ignorePatterns: [
+    'tap-testdir*/',
+  ],
   extends: [
     '@npmcli',
     ...localConfigs,
@@ -5889,6 +5910,8 @@ workspaces/a/.gitignore
 
 # ignore everything in the root
 /*
+# transient test directories
+tap-testdir*/
 
 # keep these
 !**/.gitignore
@@ -5952,6 +5975,9 @@ const localConfigs = readdir(__dirname)
 
 module.exports = {
   root: true,
+  ignorePatterns: [
+    'tap-testdir*/',
+  ],
   extends: [
     '@npmcli',
     ...localConfigs,
@@ -5964,6 +5990,8 @@ workspaces/b/.gitignore
 
 # ignore everything in the root
 /*
+# transient test directories
+tap-testdir*/
 
 # keep these
 !**/.gitignore

tap-snapshots/test/check/snapshots.js.test.cjs

@@ -120,6 +120,7 @@ The following files are tracked by git but matching a pattern in .gitignore:
 To correct it: move files to not match one of the following patterns:
 
   /*
+  tap-testdir*/
   !**/.gitignore
   !/.commitlintrc.js
   !/.eslintrc.js
@@ -159,6 +160,7 @@ The following files are tracked by git but matching a pattern in .gitignore:
 To correct it: move files to not match one of the following patterns:
 
   /*
+  tap-testdir*/
   !**/.gitignore
   !/.commitlintrc.js
   !/.eslintrc.js
@@ -196,6 +198,7 @@ The following files are tracked by git but matching a pattern in workspaces/a/.g
 To correct it: move files to not match one of the following patterns:
 
   /*
+  tap-testdir*/
   !**/.gitignore
   !/.eslintrc.js
   !/.eslintrc.local.*
@@ -221,6 +224,7 @@ The following files are tracked by git but matching a pattern in workspaces/b/.g
 To correct it: move files to not match one of the following patterns:
 
   /*
+  tap-testdir*/
   !**/.gitignore
   !/.eslintrc.js
   !/.eslintrc.local.*

workspace/test-workspace/.eslintrc.js

@@ -10,6 +10,9 @@ const localConfigs = readdir(__dirname)
 
 module.exports = {
   root: true,
+  ignorePatterns: [
+    'tap-testdir*/',
+  ],
   extends: [
     '@npmcli',
     ...localConfigs,

workspace/test-workspace/.gitignore

@@ -2,6 +2,8 @@
 
 # ignore everything in the root
 /*
+# transient test directories
+tap-testdir*/
 
 # keep these
 !**/.gitignore