-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package scripts should use upstream
, not origin
, to set repository.url from git
#363
Comments
origin
for setting URLsupstream
, not origin
, to set repository.url from git
This tool is mainly designed to run in other repos where Probably the best thing to do here is skip that check when specifically in this Alternatively we could do the same thing we do in |
This issue does not just impact contributing to the
and it goes on like this for several more packages. |
<!-- What / Why --> <!-- Describe the request in detail. What it does and why it's being changed. --> By default the gh cli operates against the upstream repo when you run commands like `gh pr checkout ...`. For the purposes of stafftools, we want to operate against the forked repo, so we run `gh repo set-default npm/{name}`. Tested with `node ./bin/gh.mjs template-oss-fix --install --filter 'name:json-parse-even-better-errors'` after removing `~/projects/npm/json-parse-even-better-errors`. Also tested with `node ./bin/gh.mjs repos clone --filter "name:agent"`, to ensure clone still works for non-forked repos. ## References <!-- Examples: Related to #0 Depends on #0 Blocked by #0 Fixes #0 Closes #0 --> Change to favor the upstream remote: npm/template-oss#363 npm/json-parse-even-better-errors#65 cli/cli#9261 (comment) cli/cli#6777
The repository URLs are based on assuming that
origin
is the authoritative url and updatespackage.json
based on this. In the case of this repo, it causes tests to fail locally.This should be expecting
origin
to be the default branch to push/pull andupstream
to be the authoritative repo because:Per @lukekarrys in #338 (comment)
The text was updated successfully, but these errors were encountered: