fix: Use include-workspace-root for /main in Post Dependabot
#462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashtagchris
changed the title
include-workspace-root for target branch in post-dependabot.ymlinclude-workspace-root for /main in post-dependabot.yml
hashtagchris
changed the title
include-workspace-root for /main in post-dependabot.ymlinclude-workspace-root for /main in Post Dependabot
hashtagchris
force-pushed
the
hashtagchris-dependabot-outputs-directory
branch
from
eff36c1 to
cd4f1a4
Compare
wraithgar
approved these changes
Jul 17, 2024
|
stafftools will still need to be ran on dependabot PRs that update |
Merged
wraithgar
pushed a commit
that referenced
this pull request
Jul 17, 2024
🤖 I have created a release *beep* *boop* --- ## [4.23.1](v4.23.0...v4.23.1) (2024-07-17) ### Bug Fixes * [`ca47705`](ca47705) [#462](#462) Use `include-workspace-root` for `/main` in Post Dependabot (#462) (@hashtagchris) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Aug 7, 2024
This was referenced Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
steps.metadata.outputs.directoryis set to/main, not/, whenpackage.jsonis at the root of the repository. I suspect addingtarget-branchtodependabot.yml(#330) added amainsegment to Dependabot PR branch names, which changed the value ofsteps.metadata.outputs.directory.By fixing this issue, we shouldn't need to routinely use stafftools to fix up template-oss Dependabot PRs. 🤞🏼
I couldn't quickly find a
bump @npmcli/template-ossDependabot PR for a workspace to inspectsteps.metadata.outputs.directoryand fix workspaces support. If that's important, we may want to either enable Dependabot fornpm/clior create a separatetemplate-oss-testrepo. It's not clear if Dependabot will create a PR forworkspace/test-workspaceupon our next release.Example Dependabot PR branch names
The first PR updates just
@npmcli/template-oss. The second updates multiple dependencies including@npmcli/template-oss.dependabot/npm_and_yarn/main/npmcli/template-oss-4.23.0/maindependabot/npm_and_yarn/main/dependency-updates-4de8b5bfcf/References
Failed "Post Dependabot" run: https://github.com/npm/agent/actions/runs/9963674341/job/27530225303
Fix manually tested here: npm/agent@ef85b08
branchNameToDirectoryName
Bug report: dependabot/fetch-metadata#540