fix: Don't restrict length for commit message footer #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hashtagchris
changed the title
Tayvon
approved these changes
Aug 5, 2024
wraithgar
changed the title
Merged
hashtagchris
added a commit
that referenced
this pull request
Aug 5, 2024
<!-- What / Why --> <!-- Describe the request in detail. What it does and why it's being changed. --> Our breaking change footers related to engine changes are often >100 characters, resulting in commitlint CI failures. <!-- Examples: Related to #0 Depends on #0 Blocked by #0 Fixes #0 Closes #0 --> Example CI failure: https://github.com/npm/ssri/actions/runs/10169599799/job/28126863705#step:7:12 Associated PR: npm/ssri#137
wraithgar
pushed a commit
that referenced
this pull request
Aug 13, 2024
🤖 I have created a release *beep* *boop* --- ## [4.23.2](v4.23.1...v4.23.2) (2024-08-13) ### Bug Fixes * [`fa37073`](fa37073) [#469](#469) proper workspace tap config for tap18 and up (@wraithgar) * [`6a2200d`](6a2200d) [#465](#465) omit nyc config for all tap versions above 18 (#465) (@wraithgar) * [`6ee703d`](6ee703d) Don't restrict length for commit message footer (#467) (@hashtagchris) * [`87d3ed9`](87d3ed9) [#466](#466) update codeql runner version (#466) (@wraithgar) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A breaking change footer like the one below is over 100 characters, resulting in commitlint CI failures.
References
Example CI failure: https://github.com/npm/ssri/actions/runs/10169599799/job/28126863705#step:7:12
Associated PR: npm/ssri#137