This repository was archived by the owner on Jul 28, 2021. It is now read-only.
feat(profile): add profile subcommands
#28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @zkat, I have some questions.
Thanks! |
TODO: OTP code, TFA
alopezsanchez
force-pushed
the
feature/profile
branch
from
8b80c17 to
1008a01
Compare
alopezsanchez
changed the title
profile commandprofile subcommands
|
@zkat If you think that Btw, I have some improvements in my TODO list:
|
zkat
reviewed
Nov 20, 2018
lib/commands/profile.jsx
Outdated
|
|
||
| async function enable2fa (argv) { | ||
| const url = require('url') | ||
| const queryString = require('query-string') |
There was a problem hiding this comment.
Why not use the built-in querystring module?
There was a problem hiding this comment.
You are right. Changed 👍
lib/commands/profile.jsx
Outdated
|
|
||
| const getOptions = argv => ProfileConfig(npmConfig().concat(argv).concat({ log })) | ||
|
|
||
| // TODO: Move to `../utils`? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://www.npmjs.com/package/npm-profile
Ref: https://docs.npmjs.com/cli/profile.html
Ref: https://docs.npmjs.com/cli/token.html
adduserloginadduserWebloginWebadduserCouchloginCouchgetsetenable-2fadisable-2faset passwordlistTokensremoveTokencreateToken