Use fast, documented generator instead of slow, undocumented generator #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crypto.pseudoRandomBytes is deprecated on nodejs:master. This replaces the call to the deprecated API with crypto.randomBytes which is functionally equivalent.
4 tasks
Contributor
|
This will fix an issue that results in a broken test in I updated |
Contributor
Sheepish update: The warning was only causing problems because I run with Still, it would be great to move off the deprecated alias and use the supported name for the function. This way, if Node.js ever does runtime-deprecate the alias, |
tniessen
changed the title
tniessen
changed the title
Contributor
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crypto.pseudoRandomBytesis deprecated on nodejs:master, see nodejs/node@221df22. This replaces the call to the deprecated API withcrypto.randomByteswhich is functionally equivalent.In recent versions of Node.js,crypto.randomBytesusually produces pseudo-random bytes with no delay. Only if the CSPRNG provided by OpenSSL is not properly seeded and the system is low on entropy a noticeable delay of a few milliseconds can occur, which is basically never.I changed this PR to produce non-cryptographically strong pseudorandom numbers after talking to @iarna about it. This is about two to three times faster and has a similar entropy.