-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
コンポーネントの追加 #40
コンポーネントの追加 #40
Conversation
https://github.com/cccties/ChibiCHiLO/pull/40/checks?check_run_id=1395249516#step:5:7 ciのフォーマットのジョブのコミットするステップでコケているようですね |
git remoteが適切に与えられていないようでコミットの反映に失敗していますね… |
chore: adjust path alias refactor: split styles to styles directory
const cardClasses = useCardStyles(); | ||
const inputLabelClasses = useInputLabelStyles(); | ||
const classes = useStyles(); | ||
const [language, setLanguage] = useState("ja"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Selectがちゃんと動かしたかったからSelectだけuseStateを書いているけど、ここはBookの入力項目を入れたいので、最終的には、BookのuseStateを書いて、
setBook({ ...book, language: event.target.value })
のような感じに書くのかなとは思っている
@kou029w |
と思ったらciで何か出ていて、私が直せそうなのでもう少しだけ触ります |
@kou029w 終わりました! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
const inputClasses = useInputStyles(); | ||
const [value, setValue] = useState("name-descend"); | ||
const handleChange = (event: ChangeEvent<{ value: unknown }>) => { | ||
setValue(event.target.value as string); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ここだけなぜか ChangeEvent<HTMLInputElement>
で指定すると
Type '(event: ChangeEvent<HTMLInputElement>) => void' is not assignable to type '(event: ChangeEvent<{ name?: string | undefined; value: unknown; }>, child: ReactNode) => void'.
Types of parameters 'event' and 'event' are incompatible.
Type 'ChangeEvent<{ name?: string | undefined; value: unknown; }>' is not assignable to type 'ChangeEvent<HTMLInputElement>'.
Type '{ name?: string | undefined; value: unknown; }' is missing the following properties from type 'HTMLInputElement': accept, align, alt, autocomplete, and 285 more.
と言われてしまうのでstringにキャストアサーションした
Co-authored-by: Kohei Watanabe <kou029w@gmail.com>
…y-dialog feat: LearnerActivityDialogの実装
…create-bookmark-api feat/40
pathのaliasの追加を含んでいます