Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typographic filter sometimes inserts random $2 #64

Closed
alykat opened this issue Nov 14, 2023 · 0 comments
Closed

Typographic filter sometimes inserts random $2 #64

alykat opened this issue Nov 14, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@alykat
Copy link
Member

alykat commented Nov 14, 2023

Just noted with Books We Love:
nprapps/book-concierge#119

And noted earlier this year on the midsummer Games We Love built in this rig.

Non-urgent (there's an easy workaround) but worth looking into one of these days. Rather than modify typogr itself, i'd probably search for that string in in the processed text? Maybe here in templateFilters.js — https://github.com/nprapps/dailygraphics-next/blob/master/lib/templateFilters.js#L102-L110

Any change we'd want to apply to BWL, dgnext and the interactive template.
@alykat alykat added bug Something isn't working good first issue Good for newcomers labels Nov 14, 2023
brentajones added a commit that referenced this issue Nov 28, 2023
@brentajones
Merge pull request #65 from nprapps/smartypants-fix
d3dafd0 
fixes smartypants bug; closes #64
DanielJWood added a commit that referenced this issue Feb 8, 2024
@DanielJWood @brentajones
fixes smartypants bug; closes #64 (#67)
48cdff9 
Co-authored-by: Brent Jones <bjones@npr.org>
DanielJWood added a commit that referenced this issue Aug 12, 2024
@DanielJWood @brentajones
@alykat @hilaryfung
merge master into lineage beta view (#69)
dd949ec 
* fixes smartypants bug; closes #64

* Update readme.rst

Minor clarifications

* add a note about publishing google sheets to s3

* update example config to ga4

---------

Co-authored-by: Brent Jones <bjones@npr.org>
Co-authored-by: Alyson Hurt <ahurt@npr.org>
Co-authored-by: Hilary Fung <1105386+hilaryfung@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alykat