Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: search parent directories for .adr-dir #62

Closed
meshy opened this issue Jul 16, 2018 · 4 comments
Closed

Feature request: search parent directories for .adr-dir #62

meshy opened this issue Jul 16, 2018 · 4 comments

Comments

@meshy
Copy link

meshy commented Jul 16, 2018

In my company, ADRs live in architecture/.

I was in the architecture/ dir, and ran adr new ..., and was surprised to find that a architecture/doc/adr folder was created.

It'd be great if _adr_dir searched in parent directories to see if there was a .adr-dir, just as git searches parent directories for a .git.

Thanks for this great project, by the way! :)

@npryce
Copy link
Owner

npryce commented Jul 22, 2018

I want this and should have implemented it this way from the start. I’ll have to think about how it would interact with the behaviour described in issues #48.

@npryce
Copy link
Owner

npryce commented Jul 25, 2018

I think that this is such a significant usability improvement that it should be released first, and then #48 implemented in a way that works with the search mechanism. I have an implementation that I will push this evening.

npryce added a commit that referenced this issue Jul 25, 2018
@npryce
Copy link
Owner

npryce commented Jul 25, 2018

Implemented in 3.0.0

@npryce npryce closed this as completed Jul 25, 2018
@meshy
Copy link
Author

meshy commented Jul 26, 2018

Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants