Fix memory leaks #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not want to create a new RecipeView every time we need to refresh the recipes; this leads to leaking RecipeView objects, which have subscribed event listeners. This isn't the most elegant solution, but it gets the job done.
Also add a method to clear the contents of the RefreshView between times it is displayed. Recreating the RefreshView every time is a small memory leak.
Recreating the StashView every time we want to refresh the stash is a memory leak, and makes Procurement lag while it rebuilds the stash. As an added bonus, now the last-selected stash tab remains selected when revisiting the stash.
The onStashLoaded events were not being fired when loading character inventories, so 1) there was no loading message for these "tabs" when refreshing [used] tabs, and 2) the appropriate actions to take when reloading tabs were not happening.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.