Skip to content

Basic Example Added #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2015
Merged

Basic Example Added #9

merged 1 commit into from
Aug 2, 2015

Conversation

jayfunk
Copy link
Collaborator

@jayfunk jayfunk commented Jul 18, 2015

-Renamed the name of the exported name to be "Resizable".
-Installed browserify
-built a browser version of resizable
-added a basic example on how to use the resizable component

-Installed browserify
-built a browser version of resizable
-added a basic example on how to use the resizable component
@@ -108,4 +107,5 @@ var Resizeable = React.createClass({

});

module.exports = Resizeable;
module.exports = Resizable;
global.Resizable = Resizable;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks perfect, except for this global.Resizable, what would be the purpose? Browserify would convert this into window.Resizable right? I'm highly reluctant to pollute the global scope, if a user wants to do it he can window.Resizable = require('react-component-resizable') himself...

@nrako
Copy link
Owner

nrako commented Jul 19, 2015

Thanks @jayfunk, this is great! I just have a comment above aside that I'll be happy to merge as is. And also thanks for the typo 😇

@jayfunk
Copy link
Collaborator Author

jayfunk commented Jul 20, 2015

The only reason I did the global.Resizable is if someone is not using a
module system and is using plain old browser style work they can't use this
without needing knowledge of browserify. It allows for the built version to
be used in the browser without the need for browserify.

On Sun, Jul 19, 2015, 11:39 Nicholas Rakoto notifications@github.com
wrote:

Thanks @jayfunk https://github.com/jayfunk, this is great! I just have
a comment above aside that I'll be happy to merge as is. And also thanks
for the typo [image: 😇]


Reply to this email directly or view it on GitHub
#9 (comment)
.

nrako added a commit that referenced this pull request Aug 2, 2015
@nrako nrako merged commit 54d6bf9 into nrako:master Aug 2, 2015
jayfunk added a commit to jayfunk/react-component-resizable that referenced this pull request Oct 30, 2015
Merge pull request nrako#9 from jayfunk/master
denis-bunakalya pushed a commit to SpirentOrion/orion-react-component-resizable that referenced this pull request Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants