Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow .egsinp extension when parsing command line arguments #318

Closed
mchamberland opened this issue Jul 29, 2017 · 2 comments
Closed

Allow .egsinp extension when parsing command line arguments #318

mchamberland opened this issue Jul 29, 2017 · 2 comments
Assignees
@rtownson
Labels
improvement

Comments

@mchamberland
Copy link
Contributor

mchamberland commented Jul 29, 2017 •
edited
Loading

This is a feature request. When running an application from the command line, it would be nice if we could leave in the .egsinp extension of the input file. For example:

tutor7pp -i test1.egsinp
Right now, we get the following result:

***************** Error: 
 input file /Users/Marc/clrp/egs_home/tutor7pp/test1.egsinp.egsinp does not exist

I feel like it should be trivial to test for the existence of the .egsinp extension on the argument, but I couldn't quite get it working straight when I took a shot at it (it seems like the command line arguments get parsed in a few different places, maybe?).
rtownson added a commit that referenced this issue Jul 31, 2017
@rtownson
Fix #318: Allow extension on input argument
d20b068 
Allow the .egsinp extension in the -i argument instead of requiring no
extension.
@rtownson rtownson mentioned this issue Jul 31, 2017
Merged
rtownson added a commit that referenced this issue Jul 31, 2017
@rtownson
Fix #318: Allow extension on input argument
9cc3a30 
Allow the .egsinp extension in the -i argument instead of requiring no
extension.
rtownson added a commit that referenced this issue Jul 31, 2017
@rtownson
Fix #318: Allow extension on input argument
6ca6bad 
Allow the .egsinp extension in the -i argument instead of requiring no
extension.
rtownson added a commit that referenced this issue Jul 31, 2017
@rtownson
Fix #318: Allow extension on input argument
558d3eb 
Allow the .egsinp extension in the -i argument instead of requiring no
extension.
@rtownson rtownson self-assigned this Aug 4, 2017
blakewalters added a commit that referenced this issue Aug 9, 2017
@blakewalters
Fix #318: Bug when changing MXSTACK in array_sizes.h
549a11a 
Added array_sizes.h to the compile dependencies for
egs_interface2.c in egspp1.spec.  As discovered by @ojalaj
when running egs_chamber, without this dependency, changes
to MXSTACK--the max. dimension of variables in the STACK
common block (Fortran)--were not propagated through to
the EGS_Stack definition in egs_interface2.  The result:
mismatched variable dimensions and zero results.

A temporary workaround was to type "make clean" before "make"
after changing MXSTACK.  This forced a recompilation of
egs_interface2.c.
ftessier pushed a commit that referenced this issue Aug 18, 2017
@blakewalters @ftessier
Fix #318: changing MXSTACK in array_sizes.h
e330f38 
Add array_sizes.h to the compile dependencies for egs_interface2.c in
egspp1.spec. As discovered by @ojalaj when running egs_chamber, without
this dependency, changes to MXSTACK (the maximum dimension of variables
in the STACK Fortran common block) were not propagated through to the
EGS_Stack definition in egs_interface2. This resulted in mismatched
variable dimensions and null results.

A workaround was to run "make clean" before "make" after changing
MXSTACK, but this forced a recompilation of egs_interface2.c.
ftessier pushed a commit that referenced this issue Aug 18, 2017
@blakewalters @ftessier
Fix #318: changing MXSTACK in array_sizes.h
35f098e 
Add array_sizes.h to the compile dependencies for egs_interface2.c in
egspp1.spec. As discovered by @ojalaj when running egs_chamber, without
this dependency, changes to MXSTACK (the maximum dimension of variables
in the STACK Fortran common block) were not propagated through to the
EGS_Stack definition in egs_interface2. This resulted in mismatched
variable dimensions and null results.

A workaround was to run "make clean" before "make" after changing
MXSTACK, but this forced a recompilation of egs_interface2.c.
ftessier pushed a commit that referenced this issue Aug 18, 2017
@rtownson @ftessier
Fix #318: allow extension on input argument
20276b3 
Allow the .egsinp extension in the -i argument instead of requiring no
extension.
ftessier pushed a commit that referenced this issue Aug 18, 2017
@rtownson @ftessier
Fix #318: allow extension on input argument
f93aa70 
Allow the .egsinp extension in the -i argument instead of requiring no
extension.
@ftessier
Copy link
Member

Note: pull request #324 incorrectly refers to this issue, instead of issue #314.

@ftessier
Copy link
Member

Fixed in pull request #320.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtownson rtownson

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ftessier @mchamberland @rtownson