Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug in sprrznrc output of D/Dmax vs radius #607

Closed
dworogers opened this issue Jun 2, 2020 · 2 comments
Closed

bug in sprrznrc output of D/Dmax vs radius #607

dworogers opened this issue Jun 2, 2020 · 2 comments
Assignees
@rtownson
Labels
bug

Comments

@dworogers
Copy link

dworogers commented Jun 2, 2020 •
edited by ftessier
Loading

In sprrznrc.mortran near line 4669:

   DO IX=1, NR [
       XCOORD(IX) = RCYL(IX);
       YCOORD(IZ) = SCDOSE(IZ,IX,3)/Dmax;
       UNCERT(IZ) = SCDOSE(IZ,IX,3)*SCDOSE2(IZ,IX,3)/(Dmax*100.);
    ]

should be

   DO IX=1, NR [
       XCOORD(IX) = RCYL(IX);
       YCOORD(IX) = SCDOSE(IZ,IX,3)/Dmax;
       UNCERT(IX) = SCDOSE(IZ,IX,3)*SCDOSE2(IZ,IX,3)/(Dmax*100.);
    ]
@rtownson
Copy link
Collaborator

rtownson commented Jun 2, 2020

Yikes, thanks Dave!

@rtownson rtownson self-assigned this Jun 2, 2020
@rtownson rtownson added the bug label Jun 2, 2020
@ftessier
Copy link
Member

ftessier commented Jun 2, 2020

Thank you @dworogers! After reviewing the git "blame" view, this bug has been there at least since the port to git 5 years ago. Let me know if you need further forensics on this 😄

rtownson added a commit that referenced this issue Aug 10, 2020
@rtownson
Fix #607: Bug in sprrznrc output of D/Dmax
d50c215 
Fix a bug in the sprrznrc output of D/Dmax vs radius. The indices of the
y coordinate and uncertainty were using the z index instead of looping
over the x index.
ftessier pushed a commit that referenced this issue Aug 18, 2020
@rtownson @ftessier
Fix #607: bug in sprrznrc output of D/Dmax
24ed2c5 
Fix a bug in the sprrznrc output of D/Dmax vs radius. The indices of the
y coordinate and uncertainty were using the z index instead of looping
over the x index.
ftessier pushed a commit that referenced this issue Aug 18, 2020
@rtownson @ftessier
Fix #607: bug in sprrznrc output of D/Dmax
5e51d2c 
Fix a bug in the sprrznrc output of D/Dmax vs radius. The indices of the
y coordinate and uncertainty were using the z index instead of looping
over the x index.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rtownson rtownson

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ftessier @rtownson @dworogers