Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect geometry for exit phase space #749

Closed
TonyPopescu opened this issue Jul 12, 2021 · 2 comments
Closed

Incorrect geometry for exit phase space #749

TonyPopescu opened this issue Jul 12, 2021 · 2 comments
Assignees
Labels

Comments

@TonyPopescu
Copy link

TonyPopescu commented Jul 12, 2021

Hi Frederic, Blake, Reid and Ernesto,

In dosxyznrc.mortran (https://github.com/nrc-cnrc/EGSnrc/blob/master/HEN_HOUSE/user_codes/dosxyznrc/dosxyznrc.mortran), there is a missing equation just before line 3730 ("Write the particle to a phsp"). The code should include the following:

"to assign the correct z coordinate for a IAEA exit phase space"
IF(i_iaea_in=1)[
z(np) = z(np) + SAD_s20;
]

This was included in the Source 20 code submitted originally by JL and TP, but is now not present in the code. Without the above equation, the coordinates of the exit phase space (in BEAMnrc coordinates) would be incorrect. We did not notice this problem until now, because we have been using our own code version.

For example, consider a phantom of 20 x 20 x 40 cm^3 with the centre at the linac isocentre. In the IAEAheader for the exit phase space, we should see the following coordinate ranges in BEAMnrc coordinates:

$STATISTICAL_INFORMATION_GEOMETRY:
-10 10
-10 10
80 120

which is indeed the case with the above equation included. However, in its absence, as the current code stands, we would get the incorrect situation:

$STATISTICAL_INFORMATION_GEOMETRY:
-10 10
-10 10
-20 20

Regards,
-Tony Popescu

@rtownson
Copy link
Collaborator

Thanks Tony! Hopefully @blakewalters can take a look soon, since I think he worked on this.

@TonyPopescu
Copy link
Author

TonyPopescu commented Jul 15, 2021 via email

blakewalters pushed a commit that referenced this issue Mar 4, 2022
For IAEA phsp sources only and only when scoring
particles in BEAMnrc coordinates.

Addresses issue #749
ftessier pushed a commit that referenced this issue Jun 27, 2022
Add the source-axis distance to the z position of the particles before
the phase space is scored. This change only affects IAEA phsp sources,
and only when scoring particles in BEAMnrc coordinates.
ftessier pushed a commit that referenced this issue Jun 27, 2022
Add the source-axis distance to the z position of the particle before it
is written to the phase space file. This change only affects IAEA phsp
sources, and only when scoring particles in BEAMnrc coordinates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants