Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in egs_chamber exapmle2 #945

Closed
wkt84 opened this issue Dec 22, 2022 · 1 comment
Closed

Typo in egs_chamber exapmle2 #945

wkt84 opened this issue Dec 22, 2022 · 1 comment
Assignees

Comments

@wkt84
Copy link

wkt84 commented Dec 22, 2022

The input file of egs_chamber example seems to have tiny typos.

# A 30x30 cm^2 rectilinear region of air, infinite along the

x-planes = -30  30
y-planes = -30 30

This means 60x60cm^2, not 30x30 cm^2, right?
The same is true for the water region.

I'll send out a PR if you're willing to revise it.

@rtownson
Copy link
Collaborator

rtownson commented Jan 4, 2023

Thanks for noticing this, I'll fix it, I was planning to go through these examples anyway.

@rtownson rtownson self-assigned this Jan 4, 2023
rtownson added a commit that referenced this issue Jan 9, 2023
Fix the egs_chamber examples so that they now run without needed to
compile any BEAMnrc accelerators or make changes to the input file. Also
fix a typo in the example2 water box size.
ftessier pushed a commit that referenced this issue Jan 16, 2023
Fix the egs_chamber examples so that they now run without needing to
compile any BEAMnrc accelerators or make changes to the input file. Also
fix a typo in the example2 water box size.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants