Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QT5 migration for QT based GUI apps #263

Closed
wants to merge 1 commit into from

Conversation

crcrewso
Copy link
Contributor

@crcrewso crcrewso commented Mar 7, 2017

Egs_view, egs_configuration, egs_gui, and egs_inprz now compile and run according to QT4 to QT5 migration documentation. I've done some testing, but more is needed by those that actually use egs_inprz and egs_view.

@crcrewso crcrewso changed the base branch from master to develop March 7, 2017 15:20
@ftessier
Copy link
Member

Thanks @crcrewso! Please git commit --amend to format your commit message according to https://github.com/nrc-cnrc/EGSnrc/wiki/Git-commit-messages. And now for the more difficult question: I presume Qt5 is not widely deployed yet; so we ought to wait until we distribute this, or else create a separate gui directory for the Qt5 versions?

@crcrewso
Copy link
Contributor Author

crcrewso commented Mar 24, 2017 via email

@ftessier ftessier requested review from mainegra and removed request for mainegra March 24, 2017 19:34
@ftessier ftessier added this to the Release 2018 milestone Mar 24, 2017
@ftessier
Copy link
Member

Thanks for the update, we'll look into it and consider moving to Qt5. At any rate I will mark it as Release 2018 material!

Egs_view, egs_configuration, egs_gui, and egs_inprz now compile and run
according to the official QT4 to QT5 migration documentation

This code has been tested under the Ubuntu distributed libraries in
14.04 and 16.04, it has not been tested against static libraries.

I do not use egs_inprz or egs_view much, it would be very much
appreciated if another user could do some GUI testing please. I believe
this commit to have very few bugs but I cannot be diligent enough to say
it's bug free. .
@crcrewso
Copy link
Contributor Author

@ftessier

I updated the commit message, please let me know if it is still not perfect.

When reading the wiki page you linked, I noticed this line

This only works for the most recent commit, and only until it is pushed upstream to the origin of your local branch.

I found on StackExchange a great hint on how to force the amendment when there are no code additions

@rtownson
Copy link
Collaborator

I'm closing this PR because the commit is included in PR #417. Thanks for your contribution @crcrewso!

@rtownson rtownson closed this Mar 14, 2018
@crcrewso crcrewso deleted the fix-qt5-make branch August 4, 2018 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants