Fix two bugs in iaea_phsp_source #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mainegra
approved these changes
Aug 10, 2017
rtownson
approved these changes
Aug 16, 2017
Initialize "extra" arrays with a fixed dimension MAXEXTRAS. Arrays extrafloat_type, extralong_types, extrainttemp, and extrafloattemp were initialized with zero dimension when the IAEA phsp did not store additional integers (e.g., latch) or floats (e.g., zlast) for each particle. Set latch to 0, similar to what is done in egs_phsp_source. Source had the temerity to actually assign any latch value read from the phsp file to the incident particle, not realizing that, at least in the case of egs_chamber, this variable is used for setting the splitting number. This partially fixes Issue #314 reported by @ojalaj.
ftessier
force-pushed
the
fix-iaea_phsp
branch
from
b35da7c
to
d85053b
Compare
|
Merely edited the commit message. |
ftessier
approved these changes
Aug 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrays extrafloat_type, extralong_types, extrainttemp,
extrafloattemp, could be initialized with zero dimension if
the IAEA phsp did not store any addition int (e.g. latch)
or float (e.g. zlast) variables for each particle. These
arrays are now given fixed dimension MAXEXTRAS.
Source had the temerity to actually assign any latch
value read from the phsp file to the incident particle, not
realizing that, at least in the case of egs_chamber, this
variable is used for setting splitting no. Now, latch is
set to 0, similar to egs_phsp_source. This partially fixes
the problem that @ojalaj had in Issue egs_chamber either produces zeros or exceeds MXSTACK #314.